From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757573AbZGGNYR (ORCPT ); Tue, 7 Jul 2009 09:24:17 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1756243AbZGGNYD (ORCPT ); Tue, 7 Jul 2009 09:24:03 -0400 Received: from mga03.intel.com ([143.182.124.21]:16388 "EHLO mga03.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755297AbZGGNYC (ORCPT ); Tue, 7 Jul 2009 09:24:02 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="4.42,362,1243839600"; d="scan'208";a="162308208" Date: Tue, 7 Jul 2009 21:23:51 +0800 From: Wu Fengguang To: KOSAKI Motohiro Cc: LKML , linux-mm , Andrew Morton , Rik van Riel , Minchan Kim Subject: Re: [RFC PATCH 1/2] vmscan don't isolate too many pages Message-ID: <20090707132351.GA6075@localhost> References: <20090707182947.0C6D.A69D9226@jp.fujitsu.com> <20090707184034.0C70.A69D9226@jp.fujitsu.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20090707184034.0C70.A69D9226@jp.fujitsu.com> User-Agent: Mutt/1.5.18 (2008-05-17) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Jul 07, 2009 at 05:47:13PM +0800, KOSAKI Motohiro wrote: > Subject: [PATCH] vmscan don't isolate too many pages > > If the system have plenty threads or processes, concurrent reclaim can > isolate very much pages. > > And if other processes isolate _all_ pages on lru, the reclaimer can't find > any reclaimable page and it makes accidental OOM. > > The solusion is, we should restrict maximum number of isolated pages. > (this patch use inactive_page/2) Now I think this is a better solution than per-cpu throttling :) Will test it tomorrow. Acked-by: Wu Fengguang > > FAQ > ------- > Q: Why do you compared zone accumulate pages, not individual zone pages? > A: If we check individual zone, #-of-reclaimer is restricted by smallest zone. > it mean decreasing the performance of the system having small dma zone. > > > Signed-off-by: KOSAKI Motohiro > --- > mm/page_alloc.c | 27 +++++++++++++++++++++++++++ > 1 file changed, 27 insertions(+) > > Index: b/mm/page_alloc.c > =================================================================== > --- a/mm/page_alloc.c > +++ b/mm/page_alloc.c > @@ -1721,6 +1721,28 @@ gfp_to_alloc_flags(gfp_t gfp_mask) > return alloc_flags; > } > > +static bool too_many_isolated(struct zonelist *zonelist, > + enum zone_type high_zoneidx, nodemask_t *nodemask) > +{ > + unsigned long nr_inactive = 0; > + unsigned long nr_isolated = 0; > + struct zoneref *z; > + struct zone *zone; > + > + for_each_zone_zonelist_nodemask(zone, z, zonelist, > + high_zoneidx, nodemask) { > + if (!populated_zone(zone)) > + continue; > + > + nr_inactive += zone_page_state(zone, NR_INACTIVE_ANON); > + nr_inactive += zone_page_state(zone, NR_INACTIVE_FILE); > + nr_isolated += zone_page_state(zone, NR_ISOLATED_ANON); > + nr_isolated += zone_page_state(zone, NR_ISOLATED_FILE); > + } > + > + return nr_isolated > nr_inactive; > +} > + > static inline struct page * > __alloc_pages_slowpath(gfp_t gfp_mask, unsigned int order, > struct zonelist *zonelist, enum zone_type high_zoneidx, > @@ -1789,6 +1811,11 @@ rebalance: > if (p->flags & PF_MEMALLOC) > goto nopage; > > + if (too_many_isolated(gfp_mask, zonelist, high_zoneidx, nodemask)) { > + schedule_timeout_uninterruptible(HZ/10); > + goto restart; > + } > + > /* Try direct reclaim and then allocating */ > page = __alloc_pages_direct_reclaim(gfp_mask, order, > zonelist, high_zoneidx, >