From: "Paul E. McKenney" <paulmck@linux.vnet.ibm.com>
To: Jaswinder Singh Rajput <jaswinder@kernel.org>
Cc: trivial <trivial@kernel.org>, LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 16/22] trivial: fix typo "that that" in multiple files
Date: Tue, 7 Jul 2009 09:30:53 -0700 [thread overview]
Message-ID: <20090707163053.GD6692@linux.vnet.ibm.com> (raw)
In-Reply-To: <1246976551.3613.33.camel@ht.satnam>
On Tue, Jul 07, 2009 at 07:52:31PM +0530, Jaswinder Singh Rajput wrote:
>
> Replaced "that that" with "that" in multiple files
>
> Signed-off-by: Jaswinder Singh Rajput <jaswinderrajput@gmail.com>
> ---
> Documentation/RCU/rcu.txt | 2 +-
> Documentation/block/as-iosched.txt | 2 +-
> Documentation/kernel-parameters.txt | 2 +-
> Documentation/memory-barriers.txt | 2 +-
> Documentation/networking/ipvs-sysctl.txt | 2 +-
> Documentation/trace/ftrace.txt | 2 +-
> arch/ia64/hp/sim/simeth.c | 2 +-
> arch/m68k/kernel/head.S | 4 ++--
> arch/powerpc/kernel/ftrace.c | 4 ++--
> arch/s390/lib/delay.c | 2 +-
> block/cfq-iosched.c | 2 +-
> crypto/twofish_common.c | 2 +-
> drivers/char/rio/riointr.c | 2 +-
> drivers/input/serio/hp_sdc.c | 2 +-
> drivers/net/bonding/bond_alb.c | 2 +-
> drivers/s390/char/tape_34xx.c | 2 +-
> drivers/usb/wusbcore/wa-xfer.c | 2 +-
> fs/configfs/dir.c | 2 +-
> fs/direct-io.c | 2 +-
> fs/jbd/checkpoint.c | 2 +-
> fs/jbd2/checkpoint.c | 2 +-
> fs/ntfs/layout.h | 2 +-
> fs/xfs/xfs_trans.c | 2 +-
> include/linux/ieee80211.h | 2 +-
> 24 files changed, 26 insertions(+), 26 deletions(-)
>
> diff --git a/Documentation/RCU/rcu.txt b/Documentation/RCU/rcu.txt
> index 7aa2002..1f3f992 100644
> --- a/Documentation/RCU/rcu.txt
> +++ b/Documentation/RCU/rcu.txt
> @@ -30,7 +30,7 @@ o How can the updater tell when a grace period has completed
> Just as with spinlocks, RCU readers are not permitted to
> block, switch to user-mode execution, or enter the idle loop.
> Therefore, as soon as a CPU is seen passing through any of these
> - three states, we know that that CPU has exited any previous RCU
> + three states, we know that CPU has exited any previous RCU
> read-side critical sections. So, if we remove an item from a
> linked list, and then wait until all CPUs have switched context,
> executed in user mode, or executed in the idle loop, we can
As David Howells noted, this is not correct. To fix the admittedly
awkward phrasing, how about the following?
Just as with spinlocks, RCU readers are not permitted to block,
switch to user-mode execution, or enter the idle loop. Therefore,
as soon as a given CPU is seen passing through any of these
three states, we know that this CPU has exited any previous RCU
read-side critical sections. So, if we remove an item from a
linked list, and then wait until all CPUs have switched context,
executed in user mode, or executed in the idle loop, we can
Thanx, Paul
next prev parent reply other threads:[~2009-07-07 16:31 UTC|newest]
Thread overview: 40+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-07-07 14:03 [GIT PULL] [PATCH 0/22] trivial fixes typo "foo foo" Jaswinder Singh Rajput
2009-07-07 14:05 ` [PATCH 1/22] trivial: fix typo "a a" in multiple files Jaswinder Singh Rajput
2009-07-07 14:06 ` [PATCH 2/22] trivial: fix typo "and and" " Jaswinder Singh Rajput
2009-07-07 14:08 ` [PATCH 3/22] trivial: fix typo "are are" " Jaswinder Singh Rajput
2009-07-07 14:09 ` [PATCH 4/22] trivial: fix typo "as as" " Jaswinder Singh Rajput
2009-07-07 14:10 ` [PATCH 5/22] trivial: fix typo "be be" " Jaswinder Singh Rajput
2009-07-07 14:11 ` [PATCH 6/22] trivial: fix typo "bit bit" " Jaswinder Singh Rajput
2009-07-07 14:12 ` [PATCH 7/22] trivial: fix typo "by by" " Jaswinder Singh Rajput
2009-07-07 14:13 ` [PATCH 8/22] trivial: fix typo "can can" Jaswinder Singh Rajput
2009-07-07 14:15 ` [PATCH 9/22] trivial: fix typo "could could" in multiple files Jaswinder Singh Rajput
2009-07-07 14:16 ` [PATCH 10/22] trivial: fix typo "from from" " Jaswinder Singh Rajput
2009-07-07 14:17 ` [PATCH 11/22] trivial: fix typo "has has" " Jaswinder Singh Rajput
2009-07-07 15:27 ` David Howells
2009-07-07 14:18 ` [PATCH 12/22] trivial: fix typo "lock lock" Jaswinder Singh Rajput
2009-07-07 14:19 ` [PATCH 13/22] trivial: fix typo "on on" in multiple files Jaswinder Singh Rajput
2009-07-07 15:29 ` David Howells
2009-07-07 14:20 ` [PATCH 14/22] trivial: fix typo "should should" " Jaswinder Singh Rajput
2009-07-07 14:21 ` [PATCH 15/22] trivial: fix typo "test test" Jaswinder Singh Rajput
2009-07-07 14:22 ` [PATCH 16/22] trivial: fix typo "that that" in multiple files Jaswinder Singh Rajput
2009-07-07 15:37 ` David Howells
2009-07-07 16:33 ` Paul E. McKenney
2009-07-07 17:17 ` David Howells
2009-07-07 16:30 ` Paul E. McKenney [this message]
2009-07-07 16:49 ` Jaswinder Singh Rajput
2009-07-07 14:23 ` [PATCH 17/22] trivial: fix typo "this this" " Jaswinder Singh Rajput
2009-07-07 14:24 ` [PATCH 18/22] trivial: fix typo "too too" Jaswinder Singh Rajput
2009-07-07 14:24 ` [PATCH 19/22] trivial: fix typo "was was" in multiple files Jaswinder Singh Rajput
2009-07-07 14:25 ` [PATCH 20/22] trivial: fix typo "we we" " Jaswinder Singh Rajput
2009-07-07 14:26 ` [PATCH 21/22] trivial: fix typo "with with" " Jaswinder Singh Rajput
2009-07-07 14:26 ` [PATCH 22/22] trivial: fix typo "you you" Jaswinder Singh Rajput
2009-07-07 15:44 ` [GIT PULL] [PATCH 0/22] trivial fixes typo "foo foo" David Howells
2009-07-07 16:11 ` Jesse Barnes
2009-07-07 22:15 ` Jiri Kosina
2009-07-08 4:18 ` Jaswinder Singh Rajput
2009-07-08 8:40 ` David Howells
2009-07-07 16:46 ` Jaswinder Singh Rajput
2009-07-07 16:30 ` [GIT PULL] V2 " Jaswinder Singh Rajput
2009-07-10 3:11 ` Jaswinder Singh Rajput
2009-07-10 8:42 ` Jiri Kosina
2009-07-10 8:49 ` Jaswinder Singh Rajput
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090707163053.GD6692@linux.vnet.ibm.com \
--to=paulmck@linux.vnet.ibm.com \
--cc=jaswinder@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=trivial@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox