Re: [PATCH] exec: Make do_coredump more robust and safer when using pipes in core_pattern

Andi Kleen
2009-06-28T19:31:22Z

> One way would be to add a new sysctl-externs.h and then put all the
> declarations in there. That file gets included by sysctl.c and by each
> file which shares a global with sysctl.c

Long ago I had a experimental patch to put sysctls into a new ELF section. The
you could simply put a DEFINE_SYSCTL(....) into the appropiate source file
which defined the variable and most of the tables went.

No externs, no mess, no patch collisions, everything much nicer.

The only problem was that it didn't support the numerical sysctl
space, so that would need to be removed first.

It's deprecated for quite some time now:

if (msg_count < 5) {
msg_count++;
printk(KERN_INFO
"warning: process `%s' used the deprecated sysctl "
"system call with ", current->comm);

Should it finally go now? If yes I could polish up the old patch again.

-Andi
--
ak@linux.intel.com -- Speaking for myself only.