[PATCH 0/2] do_coredump: misc cleanups

Oleg Nesterov
2009-06-26T22:29:23Z

On 06/26, Neil Horman wrote:
>
> On Fri, Jun 26, 2009 at 06:59:08PM +0200, Oleg Nesterov wrote:
> >
> > Doesn't look good, if core_pattern starts with "|" any user can set
> > RLIMIT_CORE = 0 and then just do
> >
> > for (;;)
> > if (pid = fork())
> > kill(pid, SIGQUIT);
> >
> > to DOS printk/syslog, no?
> >
> I don't think SIGQUIT will trigger this, but SIGSEGV will.

SIGQUIT falls into SIG_KERNEL_COREDUMP_MASK too.

> Regardless, if you
> do that, I would think you have bigger problems on your system.

OK, agreed.

Neil, I think you are doing useful changes, but can't we cleanup
do_coredump() first?

I just can't look at unnecessary "if (ispipe)" checks...

Oleg.