Re: [PATCH 0/2] do_coredump: misc cleanups

Neil Horman
2009-06-26T22:58:10Z

On Fri, Jun 26, 2009 at 09:14:18PM +0200, Oleg Nesterov wrote:
> On 06/26, Neil Horman wrote:
> >
> > On Fri, Jun 26, 2009 at 06:59:08PM +0200, Oleg Nesterov wrote:
> > >
> > > Doesn't look good, if core_pattern starts with "|" any user can set
> > > RLIMIT_CORE = 0 and then just do
> > >
> > > for (;;)
> > > if (pid = fork())
> > > kill(pid, SIGQUIT);
> > >
> > > to DOS printk/syslog, no?
> > >
> > I don't think SIGQUIT will trigger this, but SIGSEGV will.
>
> SIGQUIT falls into SIG_KERNEL_COREDUMP_MASK too.
>
> > Regardless, if you
> > do that, I would think you have bigger problems on your system.
>
> OK, agreed.
>
>
> Neil, I think you are doing useful changes, but can't we cleanup
> do_coredump() first?
>
Thank you, and yes, I've got no problem cleaning up do_coredump first

> I just can't look at unnecessary "if (ispipe)" checks...
>
I can get behind that. I've got some stuff to do this weekend, so I'll wait to
let Andrew roll in your cleanup patches that you've posted (I've got a bunch of
weekend chores anyway), then early next week I'll rediff my patches with your
changes in place + Andrews new set of notes.

Thanks!
Neil

P.S. Andrew - I doubled checked, and my patches are on a branch in my git tree
rooted at tag v2.6.28-rc2 with your latest mm1 patch applied:
http://www.kernel.org/pub/linux/kernel/people/akpm/patches/2.6/2.6.28-rc2/2.6.28-rc2-mm1/2.6.28-rc2-mm1.bz2
So I'm not sure where the conflicts are comming from. I'll re-clone the tree
and apply everything from scratch though once Olegs patches are in place, to see
if theres something I missed.

> Oleg.
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at http://www.tux.org/lkml/
>