Re: [PATCH] exec: Make do_coredump more robust and safer when using pipes in core_pattern

Eric W. Biederman
2009-06-28T21:51:09Z

Andrew Morton <akpm@linux-foundation.org> writes:

> On Sun, 28 Jun 2009 23:00:54 +0200 Andi Kleen <andi@firstfloor.org> wrote:
>
>> >
>> > When was the last time we saw a "warning: process `%s' used the
>> > obsolete bdflush system call" warning? A quick google here says 2004.
>> > Is that data? A bit, I guess.
>>
>> bdflush?
>
> I don't understand your answer.
>
> Many years ago (guess: 2001/2002) the bdflush() syscall was deprecated
> and we did
>
> if (msg_count < 5) {
> msg_count++;
> printk(KERN_INFO
> "warning: process `%s' used the obsolete bdflush"
> " system call\n", current->comm);
> printk(KERN_INFO "Fix your initscripts?\n");
> }
>
> to encourage people to stop using it. A brief search indicates that
> nobody has reported this message in 4-5 years.
>
> So to answer the question "how long must we leave things in place before
> removing them?", that's the only data I am aware of.

Good point. I just did a quick search and I can find people hitting the
deprecated sysctl message in 2.6.30. So next year might be too soon
to actually remove the code. Still we can remove the internal APIs
for 2.6.32 so it is no big deal.

Eric