Re: [PATCH] exec: Make do_coredump more robust and safer when using pipes in core_pattern

Andrew Morton
2009-06-26T16:21:22Z

On Fri, 26 Jun 2009 06:48:04 -0400 Neil Horman <nhorman@tuxdriver.com> wrote:

> > > --- a/kernel/sysctl.c
> > > +++ b/kernel/sysctl.c
> > > @@ -75,6 +75,7 @@ extern int max_threads;
> > > extern int core_uses_pid;
> > > extern int suid_dumpable;
> > > extern char core_pattern[];
> > > +extern unsigned int core_pipe_limit;
> >
> > Bah.
> >
> > We should fix this one day.
> >
> Is there a particular way you'd like to see it fixed?

Not in the context of this patch.

One way would be to add a new sysctl-externs.h and then put all the
declarations in there. That file gets included by sysctl.c and by each
file which shares a global with sysctl.c