public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Jens Axboe <jens.axboe@oracle.com>
To: James Bottomley <James.Bottomley@HansenPartnership.com>
Cc: Daniel Walker <dwalker@fifo99.com>,
	Maciej Rutecki <maciej.rutecki@gmail.com>,
	Andrew Morton <akpm@linux-foundation.org>,
	Tarkan Erimer <tarkan.erimer@turknet.net.tr>,
	linux-kernel@vger.kernel.org, linux-scsi@vger.kernel.org
Subject: Re: [BUG] Linux-2.6.31-rc1-git9 Cannot Recognize Empty DVD Media
Date: Wed, 8 Jul 2009 18:57:28 +0200	[thread overview]
Message-ID: <20090708165728.GU23611@kernel.dk> (raw)
In-Reply-To: <1247071445.4159.214.camel@mulgrave.site>

On Wed, Jul 08 2009, James Bottomley wrote:
> On Wed, 2009-07-08 at 09:06 -0700, Daniel Walker wrote:
> > On Wed, 2009-07-08 at 09:27 -0500, James Bottomley wrote:
> > > 
> > > You might also try this patch from martin petersen:  it will print out
> > > the actual command that's causing the problems ... that might give a
> > > clue.
> > > 
> > > James
> > 
> > On the bugzilla entry ,
> > 
> > http://bugzilla.kernel.org/show_bug.cgi?id=13727
> > 
> > Thomas Meyer indicated it was (possibly) the following commit,
> > 
> > 018e0446890661504783f92388ecce7138c1566d
> > 
> > I added Jens to the CC ..
> 
> So thats:
> 
> commit 018e0446890661504783f92388ecce7138c1566d
> Author: Jens Axboe <jens.axboe@oracle.com>
> Date:   Fri Jun 26 16:27:10 2009 +0200
> 
>     block: get rid of queue-private command filter
> 
> What this tends to suggest is that the command filter was blocking some
> type of command sent from user space which is causing the problem, and
> now we're letting it through.  Restoring the command filter will work
> around the problem, but the root cause should be finding and fixing
> whatever is issuing the commands in the first place.

There should be no functional change, since the filters were all the
same. Perhaps blk_scsi_ioctl_init() isn't being run, a good start would
be to stick a printk() in there and verify that it's actually being
executed. I've been tricked by __init before.

-- 
Jens Axboe


  reply	other threads:[~2009-07-08 16:57 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-07-02 13:23 [BUG] Linux-2.6.31-rc1-git9 Cannot Recognize Empty DVD Media Tarkan Erimer
2009-07-02 20:07 ` Andrew Morton
2009-07-08 13:09   ` Maciej Rutecki
2009-07-08 14:27     ` James Bottomley
2009-07-08 16:06       ` Daniel Walker
2009-07-08 16:44         ` James Bottomley
2009-07-08 16:57           ` Jens Axboe [this message]
2009-07-08 23:49             ` FUJITA Tomonori
2009-07-08 23:54               ` FUJITA Tomonori
2009-07-09  6:27               ` Maciej Rutecki
2009-07-09  7:50               ` Jens Axboe
2009-07-09  8:08                 ` FUJITA Tomonori
2009-07-09  8:12                   ` Jens Axboe
2009-07-08 18:22           ` Maciej Rutecki
2009-07-08 22:52       ` Martin K. Petersen
2009-07-09  4:28         ` James Bottomley

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20090708165728.GU23611@kernel.dk \
    --to=jens.axboe@oracle.com \
    --cc=James.Bottomley@HansenPartnership.com \
    --cc=akpm@linux-foundation.org \
    --cc=dwalker@fifo99.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-scsi@vger.kernel.org \
    --cc=maciej.rutecki@gmail.com \
    --cc=tarkan.erimer@turknet.net.tr \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox