Re: [PATCH 02/12] SFI, x86: add CONFIG_SFI

Ingo Molnar
2009-07-10T05:23:34Z

* Len Brown <lenb@kernel.org> wrote:

> +++ b/drivers/sfi/Kconfig
> @@ -0,0 +1,16 @@
> +#
> +# SFI Configuration
> +#
> +
> +menuconfig SFI
> + bool "SFI (Simple Firmware Interface) Support"
> + depends on X86

Instead of 'depends on X86' it's cleaner to add a HAVE_ARCH_SFI
Kconfig variable to arch/x86/Kconfig, and turn the above into:

depends on HAVE_ARCH_SFI

That will make it easier to enable it on other architectures such as
IA64, should the need arise - and it's cleaner in any case.

> + default n

Kconfig uses 'default n' by default, so this line can be left out.

> + ---help---
> + The Simple Firmware Interface (SFI) provides a lightweight method
> + for platform firmware to pass information to the Operating System
> + via static tables in memory.
> +
> + For more information, see http://simplefirmware.org
> +
> + Say 'Y' here to enable the kernel to boot on SFI-only platforms.

Nitpick: s/Operating System/Linux kernel

(and even if we want to formulate it in a general way, it should be
'operating system')

Ingo