Re: [PATCH 03/12] SFI: document boot param "sfi=off"

Bjorn Helgaas
2009-07-28T19:24:09Z

On Tuesday 07 July 2009 10:13:49 pm Len Brown wrote:
> From: Feng Tang <feng.tang@intel.com>
>
> "sfi=off" is analogous to "acpi=off"
>
> In practice, "sfi=off" isn't likely to be very useful, for
> 1. SFI is used only when ACPI is not available
> 2. Today's SFI systems are not legacy PC-compatible
>
> ie. "sfi=off" on an ACPI-platform is a NO-OP,
> and "sfi=off" on an SFI-platform will likely result in boot failure.
>
> Signed-off-by: Feng Tang <feng.tang@intel.com>
> Signed-off-by: Len Brown <len.brown@intel.com>
> ---
> Documentation/kernel-parameters.txt | 5 +++++
> 1 files changed, 5 insertions(+), 0 deletions(-)

I think the documentation update should be part of the patch
that changes the functionality, so the doc always matches the
code.

Bjorn

> diff --git a/Documentation/kernel-parameters.txt b/Documentation/kernel-parameters.txt
> index d77fbd8..68337e6 100644
> --- a/Documentation/kernel-parameters.txt
> +++ b/Documentation/kernel-parameters.txt
> @@ -92,6 +92,7 @@ parameter is applicable:
> SECURITY Different security models are enabled.
> SELINUX SELinux support is enabled.
> SERIAL Serial support is enabled.
> + SFI Simple Firmware Interface
> SH SuperH architecture is enabled.
> SMP The kernel is an SMP kernel.
> SPARC Sparc architecture is enabled.
> @@ -2162,6 +2163,10 @@ and is between 256 and 4096 characters. It is defined in the file
> If enabled at boot time, /selinux/disable can be used
> later to disable prior to initial policy load.
>
> + sfi= [SFI,X86] Simple Firmware Interface
> + Format: { "off" }
> + off -- disable SFI
> +
> serialnumber [BUGS=X86-32]
>
> shapers= [NET]