From: Sten Spans <Sten_Spans@genua.de>
To: linux-kernel@vger.kernel.org
Subject: security_file_lock cmd argument
Date: Thu, 9 Jul 2009 11:45:44 +0200 [thread overview]
Message-ID: <20090709094544.GA23769@false> (raw)
I was playing around with the security_file_lock hook which
is invoked from fs/locks.c. The desciption in include/linux/security.h
states the following:
* @file_lock:
* Check permission before performing file locking operations.
* Note: this hook mediates both flock and fcntl style locks.
* @file contains the file structure.
* @cmd contains the posix-translated lock operation to perform
* (e.g. F_RDLCK, F_WRLCK).
However when invoked via sys_flock:
SYSCALL_DEFINE2(flock, unsigned int, fd, unsigned int, cmd)
{
..
error = security_file_lock(filp, cmd);
Which results in passing flock style arguments (LOCK_*) rather
than fcntl (F_*LCK). This also is inconsistent with the two
other security_file_lock invocations in the same file.
This one-liner fixes the issue:
--- fs/locks.c.orig 2009-07-09 11:26:45.000000000 +0200
+++ fs/locks.c 2009-07-09 11:27:24.000000000 +0200
@@ -1590,7 +1590,7 @@
if (can_sleep)
lock->fl_flags |= FL_SLEEP;
- error = security_file_lock(filp, cmd);
+ error = security_file_lock(filp, lock->fl_type);
if (error)
goto out_free;
--
GeNUA Gesellschaft für Netzwerk - und Unix-Administration mbH
Domagkstr. 7, D-85551 Kirchheim. http://www.genua.de
Tel: (089) 99 19 50-0, Fax: (089) 99 19 50 - 999
Geschäftsführer: Dr. Magnus Harlander, Dr. Michaela Harlander,
Bernhard Schneck. Amtsgericht München HRB 98238
next reply other threads:[~2009-07-09 10:00 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-07-09 9:45 Sten Spans [this message]
[not found] <alpine.LRH.2.00.0907092031020.4944@tundra.namei.org>
2009-07-16 0:05 ` security_file_lock cmd argument James Morris
2009-07-16 7:41 ` Sten Spans
2009-07-16 22:04 ` James Morris
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090709094544.GA23769@false \
--to=sten_spans@genua.de \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox