From: Thomas Renninger <trenn@suse.de>
To: Daniel Mack <daniel@caiaq.de>
Cc: linux-kernel@vger.kernel.org,
Mathieu Desnoyers <mathieu.desnoyers@polymtl.ca>,
Venkatesh Pallipadi <venkatesh.pallipadi@intel.com>,
rjw@sisk.pl, mingo@elte.hu, Shaohua Li <shaohua.li@intel.com>,
Pekka Enberg <penberg@cs.helsinki.fi>,
Dave Young <hidave.darkstar@gmail.com>,
Rusty Russell <rusty@rustcorp.com.au>,
sven.wegener@stealer.net, cpufreq@vger.kernel.org,
Dave Jones <davej@redhat.com>
Subject: [PATCH] cpufreq: Unbreak build for !SMP: symlinked cpus cannot happen for !SMP
Date: Thu, 9 Jul 2009 10:43:35 +0200 [thread overview]
Message-ID: <200907091043.39607.trenn@suse.de> (raw)
In-Reply-To: <1247081067-21964-1-git-send-email-daniel@caiaq.de>
Or like that:
Either all #ifdef CONFIG_SMP related conditionals to managed cpus
should vanish or all should be covered. This one takes the latter
approach.
---
'managed_policy' is used for the non-smp case in line 941.
Make the symlink code conditional to #ifdef CONFIG_SMP as already
done at other places.
Signed-off-by: Thomas Renninger <trenn@suse.de>
Index: cpufreq/drivers/cpufreq/cpufreq.c
===================================================================
--- cpufreq.orig/drivers/cpufreq/cpufreq.c
+++ cpufreq/drivers/cpufreq/cpufreq.c
@@ -930,6 +930,7 @@ static int cpufreq_add_dev(struct sys_de
}
spin_unlock_irqrestore(&cpufreq_driver_lock, flags);
+#ifdef CONFIG_SMP
/* symlink affected CPUs */
for_each_cpu(j, policy->cpus) {
if (j == cpu)
@@ -947,6 +948,7 @@ static int cpufreq_add_dev(struct sys_de
goto err_out_unregister;
}
}
+#endif
policy->governor = NULL; /* to assure that the starting sequence is
* run in cpufreq_set_policy */
next prev parent reply other threads:[~2009-07-09 8:43 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-07-08 19:24 [PATCH] cpufreq: unbreak build for !CONFIG_SMP Daniel Mack
2009-07-09 8:43 ` Thomas Renninger [this message]
2009-07-09 8:48 ` [PATCH] cpufreq: Unbreak build for !SMP: symlinked cpus cannot happen for !SMP Daniel Mack
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200907091043.39607.trenn@suse.de \
--to=trenn@suse.de \
--cc=cpufreq@vger.kernel.org \
--cc=daniel@caiaq.de \
--cc=davej@redhat.com \
--cc=hidave.darkstar@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mathieu.desnoyers@polymtl.ca \
--cc=mingo@elte.hu \
--cc=penberg@cs.helsinki.fi \
--cc=rjw@sisk.pl \
--cc=rusty@rustcorp.com.au \
--cc=shaohua.li@intel.com \
--cc=sven.wegener@stealer.net \
--cc=venkatesh.pallipadi@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox