The Linux Kernel Mailing List
 help / color / mirror / Atom feed
From: Alan Cox <alan@lxorguk.ukuu.org.uk>
To: torvalds@linux-foundation.org, linux-kernel@vger.kernel.org
Subject: [PATCH 1/3] tty: Sort out the USB sysrq changes that wrecked performance
Date: Thu, 09 Jul 2009 13:35:52 +0100	[thread overview]
Message-ID: <20090709123523.15654.15754.stgit@localhost.localdomain> (raw)
In-Reply-To: <20090709123301.15654.4698.stgit@localhost.localdomain>

From: Alan Cox <alan@linux.intel.com>

We can't go around calling all sorts of magic per character functions at
full rate 3G data speed.

Signed-off-by: Alan Cox <alan@linux.intel.com>
---

 drivers/usb/serial/generic.c |   15 +++++++++++----
 1 files changed, 11 insertions(+), 4 deletions(-)


diff --git a/drivers/usb/serial/generic.c b/drivers/usb/serial/generic.c
index 932d624..e9aa7a4 100644
--- a/drivers/usb/serial/generic.c
+++ b/drivers/usb/serial/generic.c
@@ -424,10 +424,17 @@ static void flush_and_resubmit_read_urb(struct usb_serial_port *port)
 	if (!tty)
 		goto done;
 
-	/* Push data to tty */
-	for (i = 0; i < urb->actual_length; i++, ch++) {
-		if (!usb_serial_handle_sysrq_char(port, *ch))
-			tty_insert_flip_char(tty, *ch, TTY_NORMAL);
+	/* The per character mucking around with sysrq path it too slow for
+	   stuff like 3G modems, so shortcircuit it in the 99.9999999% of cases
+	   where the USB serial is not a console anyway */	
+	if (!port->console || !port->sysrq)
+		tty_insert_flip_string(tty, ch, urb->actual_length);
+	else {	
+		/* Push data to tty */
+		for (i = 0; i < urb->actual_length; i++, ch++) {
+			if (!usb_serial_handle_sysrq_char(port, *ch))
+				tty_insert_flip_char(tty, *ch, TTY_NORMAL);
+		}
 	}
 	tty_flip_buffer_push(tty);
 	tty_kref_put(tty);


  reply	other threads:[~2009-07-09 12:36 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-07-09 12:35 [PATCH 0/3] Fix sysrq caused USB performance regressions and leak Alan Cox
2009-07-09 12:35 ` Alan Cox [this message]
2009-07-09 15:49   ` [PATCH 1/3] tty: Sort out the USB sysrq changes that wrecked performance Fengwei Yin
2009-07-09 23:22     ` Fengwei Yin
2009-07-09 12:36 ` [PATCH 2/3] tty: Fix USB kref leak Alan Cox
2009-07-09 12:36 ` [PATCH 3/3] tty: Fix the PL2303 private methods for sysrq Alan Cox
2009-07-09 15:46 ` [PATCH 0/3] Fix sysrq caused USB performance regressions and leak Anders Larsen
2009-07-10  0:02   ` Alan Cox
2009-07-10  9:07     ` Anders Larsen
2009-07-10  9:34       ` Alan Cox

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20090709123523.15654.15754.stgit@localhost.localdomain \
    --to=alan@lxorguk.ukuu.org.uk \
    --cc=linux-kernel@vger.kernel.org \
    --cc=torvalds@linux-foundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox