From: Pavel Machek <pavel@ucw.cz>
To: Mark Allyn <mark.a.allyn@intel.com>
Cc: linux-kernel@vger.kernel.org, alan@linux.intel.com,
charles.f.johnson@intel.com
Subject: Re: [PATCH] This is the security processor driver for the Intel mid platform
Date: Fri, 10 Jul 2009 01:21:39 +0200 [thread overview]
Message-ID: <20090709232139.GF1469@ucw.cz> (raw)
In-Reply-To: <1247083262-17356-1-git-send-email-mark.a.allyn@intel.com>
> + *
> + * CHANGES:
> + *
> + * 2009.06.26 Initial publish
> + *
> + */
No changelogs in source files, please...
> +
> + /* start address of resident */
Eh?
> + unsigned long message_size_in_words;
> +
> +};
> +struct sep_driver_realloc_cache_resident_t {
> + /* base address */
> + unsigned long base_addr;
Most useless comment, ever.
> + /* cache size in bytes*/
> + unsigned long cache_size_in_bytes;
...and more.
> + /* new resident address */
> + unsigned long new_resident_addr;
> +
> + /* new resident address */
> + unsigned long new_shared_area_addr;
Ouch. Copy & paste error?
> + /* new base address */
> + unsigned long new_base_addr;
Did they tell you you have to document it, so you did? Bad comments
are worse than no comments...
Pavel
--
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
prev parent reply other threads:[~2009-07-10 12:07 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-07-08 20:01 [PATCH] This is the security processor driver for the Intel mid platform Mark Allyn
2009-07-08 23:17 ` Alan Cox
2009-07-09 1:19 ` James Morris
2009-07-09 14:08 ` Valdis.Kletnieks
2009-07-09 23:21 ` Pavel Machek [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090709232139.GF1469@ucw.cz \
--to=pavel@ucw.cz \
--cc=alan@linux.intel.com \
--cc=charles.f.johnson@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.a.allyn@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox