From: Oleg Nesterov <oleg@redhat.com>
To: Christoph Hellwig <hch@infradead.org>
Cc: Andrew Morton <akpm@linux-foundation.org>,
David Howells <dhowells@redhat.com>,
James Morris <jmorris@namei.org>,
"Paul E. McKenney" <paulmck@linux.vnet.ibm.com>,
Roland McGrath <roland@redhat.com>,
Stephen Smalley <sds@tycho.nsa.gov>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH -mm 1/2] rename is_single_threaded(task) to is_current_single_threaded(void)
Date: Fri, 10 Jul 2009 03:46:23 +0200 [thread overview]
Message-ID: <20090710014623.GA4723@redhat.com> (raw)
In-Reply-To: <20090710013322.GA27719@infradead.org>
On 07/09, Christoph Hellwig wrote:
>
> On Thu, Jul 09, 2009 at 11:28:47PM +0200, Oleg Nesterov wrote:
> > (on top of rework-fix-is_single_threaded.patch)
> >
> > - is_single_threaded(task) is not safe unless task == current,
> > we can't use task->signal or task->mm.
> >
> > - it doesn't make sense unless task == current, the task can
> > fork right after the check.
> >
> > Rename it to is_current_single_threaded() and kill the argument.
>
> It would be more natural to put the current first, as in
> current_is_single_threaded(). That would also fit with the various
> other current_* helpers we have.
Agreed, re-sending.
Oleg.
next prev parent reply other threads:[~2009-07-10 1:50 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-07-09 21:28 [PATCH -mm 1/2] rename is_single_threaded(task) to is_current_single_threaded(void) Oleg Nesterov
2009-07-09 23:04 ` James Morris
2009-07-10 1:33 ` Christoph Hellwig
2009-07-10 1:46 ` Oleg Nesterov [this message]
2009-07-10 1:48 ` [PATCH v2 -mm 1/2] rename is_single_threaded(task) to current_is_single_threaded(void) Oleg Nesterov
2009-07-10 14:07 ` David Howells
2009-07-10 1:48 ` [PATCH v2 -mm 2/2] current_is_single_threaded: don't use ->mmap_sem Oleg Nesterov
2009-07-10 14:07 ` David Howells
2009-07-12 22:12 ` James Morris
2009-07-13 23:56 ` Oleg Nesterov
2009-07-16 23:41 ` James Morris
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090710014623.GA4723@redhat.com \
--to=oleg@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=dhowells@redhat.com \
--cc=hch@infradead.org \
--cc=jmorris@namei.org \
--cc=linux-kernel@vger.kernel.org \
--cc=paulmck@linux.vnet.ibm.com \
--cc=roland@redhat.com \
--cc=sds@tycho.nsa.gov \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox