From: Ingo Molnar <mingo@elte.hu>
To: Jason Baron <jbaron@redhat.com>, Chris Wilson <chris@chris-wilson.co.uk>
Cc: Frederic Weisbecker <fweisbec@gmail.com>,
Peter Zijlstra <a.p.zijlstra@chello.nl>,
linux-kernel@vger.kernel.org, paulus@samba.org,
rostedt@goodmis.org
Subject: Re: [PATCH 3/2] perf_counters: add debugfs dir option
Date: Fri, 10 Jul 2009 06:17:58 +0200 [thread overview]
Message-ID: <20090710041758.GC5077@elte.hu> (raw)
In-Reply-To: <20090709144552.GA3102@redhat.com>
* Jason Baron <jbaron@redhat.com> wrote:
> On Thu, Jul 09, 2009 at 02:47:17AM +0200, Frederic Weisbecker wrote:
> > On Wed, Jul 08, 2009 at 04:17:43PM -0400, Jason Baron wrote:
> > > On Tue, Jul 07, 2009 at 10:29:20AM +0200, Peter Zijlstra wrote:
> > > > On Mon, 2009-07-06 at 17:12 -0400, Jason Baron wrote:
> > > > > Add support to 'perf list' and 'perf stat' for kernel tracepoints. The
> > > > > implementation creates a 'for_each_subsystem' and 'for_each_event' for
> > > > > easy iteration over the tracepoints. The debugfs filesystem must be mounted
> > > > > at '/sys/kernel/debug'. We can add an optional search path in the future.
> > > >
> > > > I don't have a single machine that has that mount point.
> > > >
> > > >
> > >
> > > ok, The patch below adds support for a 'PERF_DIR_DEBUGFS' environment
> > > variable. It also adds a command line for '--debugfs-dir' and
> > > '--debugfs-dir='. By default 'perf' continues to look in
> > > /sys/kernel/debug, which I believe is most common.
> > >
> > > thanks,
> > >
> > > -Jason
> > >
> > > Signed-off-by: Jason Baron <jbaron@redhat.com>
> >
> >
> >
> > Or why not parsing /etc/mtab ?
> >
> > Thanks.
> >
> >
> >
>
> good idea. I'll add that.
Have you seen:
Subject: [PATCH 2/2] perf tool: Add a trace point event parser.
from Chris Wilson? It already includes a /proc/mounts parser.
Ingo
next prev parent reply other threads:[~2009-07-10 4:18 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-07-06 21:11 [PATCH 0/2] perf_counter: add tracepoint support Jason Baron
2009-07-06 21:11 ` [PATCH 1/2] perf_counter: cleanup kernel perf counter support for tracepoints Jason Baron
2009-07-06 21:12 ` [PATCH 2/2] perf_counter: add support to the 'perf' tool " Jason Baron
2009-07-07 8:29 ` Peter Zijlstra
2009-07-08 20:17 ` [PATCH 3/2] perf_counters: add debugfs dir option Jason Baron
2009-07-09 0:47 ` Frederic Weisbecker
2009-07-09 14:45 ` Jason Baron
2009-07-10 4:17 ` Ingo Molnar [this message]
2009-07-13 7:15 ` [PATCH 2/2] perf_counter: add support to the 'perf' tool for tracepoints Ingo Molnar
2009-07-09 3:10 ` [PATCH 0/2] perf_counter: add tracepoint support Frederic Weisbecker
2009-07-09 7:58 ` Peter Zijlstra
2009-07-10 3:53 ` Ingo Molnar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090710041758.GC5077@elte.hu \
--to=mingo@elte.hu \
--cc=a.p.zijlstra@chello.nl \
--cc=chris@chris-wilson.co.uk \
--cc=fweisbec@gmail.com \
--cc=jbaron@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=paulus@samba.org \
--cc=rostedt@goodmis.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox