[patch] perf_counter : breaking parameter parsing when the command is reached

[patch] perf_counter : breaking parameter parsing when the command is reached

[Erdem Aktas]

    Once the perf parameter parser reaches a non-parameter word, that means
    the command is already found and the rest of the string is the parameter
    of this command so no need to parse more.

    As an example, when we want to run
    perf stat -- ls -al
    it is obvious that the -al is the parameter of the ls command, so we
    should able to run this like
    perf stat ls -al

    Signed-off-by: eaktas <eaktas1@gmail.com>

diff --git a/tools/perf/util/parse-options.c b/tools/perf/util/parse-options.c
index 1bf6719..4ad4962 100644
--- a/tools/perf/util/parse-options.c
+++ b/tools/perf/util/parse-options.c
@@ -284,6 +284,11 @@ int parse_options_step(struct parse_opt_ctx_t *ctx,
 			if (ctx->flags & PARSE_OPT_STOP_AT_NON_OPTION)
 				break;
 			ctx->out[ctx->cpidx++] = ctx->argv[0];
+			while (--(ctx->argc)) {
+				ctx->argv++;
+				ctx->out[ctx->cpidx++] = ctx->argv[0];
+			}
+			ctx->argc++;
 			continue;
 		}

Re: [patch] perf_counter : breaking parameter parsing when the command is reached

[Ingo Molnar]

* Erdem Aktas <eaktas1@gmail.com> wrote:

>     Once the perf parameter parser reaches a non-parameter word, that means
>     the command is already found and the rest of the string is the parameter
>     of this command so no need to parse more.
> 
>     As an example, when we want to run
>     perf stat -- ls -al
>     it is obvious that the -al is the parameter of the ls command, so we
>     should able to run this like
>     perf stat ls -al
> 
>     Signed-off-by: eaktas <eaktas1@gmail.com>
> 
> diff --git a/tools/perf/util/parse-options.c b/tools/perf/util/parse-options.c
> index 1bf6719..4ad4962 100644
> --- a/tools/perf/util/parse-options.c
> +++ b/tools/perf/util/parse-options.c
> @@ -284,6 +284,11 @@ int parse_options_step(struct parse_opt_ctx_t *ctx,
>  			if (ctx->flags & PARSE_OPT_STOP_AT_NON_OPTION)
>  				break;
>  			ctx->out[ctx->cpidx++] = ctx->argv[0];
> +			while (--(ctx->argc)) {
> +				ctx->argv++;
> +				ctx->out[ctx->cpidx++] = ctx->argv[0];
> +			}
> +			ctx->argc++;

I think there might be a simpler solution: pass in 
PARSE_OPT_STOP_AT_NON_OPTION.

Then we'll trigger this existing code in parse_options_end():

        memmove(ctx->out + ctx->cpidx, ctx->argv, ctx->argc * sizeof(*ctx->out));
        ctx->out[ctx->cpidx + ctx->argc] = NULL;
        return ctx->cpidx + ctx->argc;

which should solve the issue just as well, correct?

	Ingo