public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Ingo Molnar <mingo@elte.hu>
To: Robin Getz <rgetz@blackfin.uclinux.org>
Cc: Andrew Morton <akpm@linux-foundation.org>,
	linux-kernel@vger.kernel.org,
	Linus Torvalds <torvalds@linux-foundation.org>
Subject: Re: [PATCH] kernel.printk.c - ensure that "console enabled" messages are printed on the console
Date: Fri, 10 Jul 2009 12:25:47 +0200	[thread overview]
Message-ID: <20090710102547.GD5499@elte.hu> (raw)
In-Reply-To: <200907091308.37370.rgetz@blackfin.uclinux.org>


* Robin Getz <rgetz@blackfin.uclinux.org> wrote:

> From: Robin Getz <rgetz@blackfin.uclinux.org>
> 
> Today, when a console is registered without CON_PRINTBUFFER, end 
> users never see the announcement of it being added, and never know 
> if they missed something, if the console is really at the start or 
> not, and just leads to general confusion.
> 
> This re-orders existing code, to make sure the console is added, 
> before the "console [%s%d] enabled" is printed out - ensuring that 
> this message is _always_ seen.
> 
> This has the desired/intended side effect of making sure that 
> "console enabled:" messages are printed on the bootconsole, and 
> the real console. This does cause the same line is printed twice 
> if the bootconsole and real console are the same device, but if 
> they are on different devices, the message is printed to both 
> consoles.
> 
> Signed-off-by : Robin Getz <rgetz@blackfin.uclinux.org>
> 
> ---
> 
>  printk.c |   44 +++++++++++++++++++++++++++++---------------
>  1 file changed, 29 insertions(+), 15 deletions(-)
> 
> patch generated for -tip

Looks good, applied it to tip:core/printk for v2.6.32, thanks Robin. 

i fixed a couple of small details in the patch:

 - re-broke the commit log as it was too wide for nice git log 
   output

 - fixed a stray whitespace warned about by scripts/checkpatch.pl

 - fixed another stray whitespace found the old fashioned way

 - fixed the patch title to match the prefix used by your previous 
   commit as well

	Ingo

  reply	other threads:[~2009-07-10 10:26 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-07-04  4:17 Boot Consoles question Robin Getz
2009-07-04 10:29 ` Ingo Molnar
2009-07-04 16:07   ` Robin Getz
2009-07-07 23:49     ` Robin Getz
2009-07-10 10:28       ` Ingo Molnar
2009-07-10 14:28         ` Robin Getz
2009-07-10 16:08           ` Ingo Molnar
2009-07-09 17:08 ` [PATCH] kernel.printk.c - ensure that "console enabled" messages are printed on the console Robin Getz
2009-07-10 10:25   ` Ingo Molnar [this message]
2009-07-10 14:13     ` [PATCH] kernel.printk.c - ensure that "console enabled"messages " Robin Getz
2009-07-10 14:16       ` Ingo Molnar
2009-07-10 14:26         ` Mike Frysinger
2009-07-18  0:48     ` [PATCH] kernel.printk.c - ensure that "console enabled" messages " Andrew Morton
2009-07-20  5:29       ` Stephen Rothwell
2009-07-10 10:43   ` [tip:core/printk] printk: Ensure " tip-bot for Robin Getz

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20090710102547.GD5499@elte.hu \
    --to=mingo@elte.hu \
    --cc=akpm@linux-foundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=rgetz@blackfin.uclinux.org \
    --cc=torvalds@linux-foundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox