From: Nick Piggin <npiggin@suse.de>
To: Pekka Enberg <penberg@cs.helsinki.fi>
Cc: David Rientjes <rientjes@google.com>, Ingo Molnar <mingo@elte.hu>,
Janboe Ye <yuan-bo.ye@motorola.com>,
linux-kernel@vger.kernel.org, vegard.nossum@gmail.com,
fche@redhat.com, cl@linux-foundation.org
Subject: Re: [RFC][PATCH] Check write to slab memory which freed already using mudflap
Date: Fri, 10 Jul 2009 12:30:25 +0200 [thread overview]
Message-ID: <20090710103025.GK14666@wotan.suse.de> (raw)
In-Reply-To: <84144f020907100310gec596cfo718631df2c7d9b46@mail.gmail.com>
On Fri, Jul 10, 2009 at 01:10:11PM +0300, Pekka Enberg wrote:
> Hi David,
>
> On Fri, Jul 10, 2009 at 1:03 PM, David Rientjes<rientjes@google.com> wrote:
> > It's my opinion that slab is on its way out when there's no benchmark that
> > shows it is superior by any significant amount. If that happens (and if
> > its successor is slub, slqb, or a yet to be implemented allocator), we can
> > probably start a discussion on what's in and what's out at that time.
>
> Performance matters a lot, but it's certainly not the only priority
> here. Look at slab, it's bootstrap code is a train-wreck which bit us
> in the ass when we did the earlyslab thing and the NUMA support is
> pretty horrible. The code base hasn't received much attention for the
> past few years so unless someone steps up to clean it all, it's on
> it's way out, like it or not.
>
> So if you care about performance and have benchmarks that are _known_
> to regress, you might want to focus your efforts on SLUB and/or SLQB
> because that's where the action happens these days.
Well OTOH performance is something that has some pretty fixed limits
by the design. If SLQB has any performance problems I can't fix, I
do intend to try to take the SLAB base allocator design and implement
it with more modern SL[UQ]B coding style and bootstrap code.
The reason I made some changes with SLQB is because I was trying to
remove nr_cpus*nr_nodes*lots allocations for the alien caches, and
I think the linked list style of queueing allows you to be more flexible
in queue sizes, and more cache efficient (especially when moving them
around).
We'll see...
next prev parent reply other threads:[~2009-07-10 10:30 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-07-09 16:13 [RFC][PATCH] Check write to slab memory which freed already using mudflap Janboe Ye
2009-07-09 16:44 ` Pekka Enberg
2009-07-09 19:40 ` Janboe Ye
2009-07-10 8:47 ` Ingo Molnar
2009-07-10 8:52 ` Pekka Enberg
2009-07-10 9:03 ` Nick Piggin
2009-07-10 9:14 ` Pekka Enberg
2009-07-10 9:29 ` Nick Piggin
2009-07-10 9:40 ` Pekka Enberg
2009-07-10 9:47 ` David Rientjes
2009-07-10 9:51 ` Pekka Enberg
2009-07-10 10:03 ` David Rientjes
2009-07-10 10:10 ` Pekka Enberg
2009-07-10 10:30 ` Nick Piggin [this message]
2009-07-15 14:59 ` Nick Piggin
2009-07-15 20:19 ` David Rientjes
2009-07-20 8:32 ` Nick Piggin
2009-07-10 9:41 ` David Rientjes
2009-07-10 9:46 ` Pekka Enberg
2009-07-10 9:04 ` David Rientjes
2009-07-10 9:19 ` Nick Piggin
2009-07-10 9:19 ` Pekka Enberg
2009-07-10 9:31 ` David Rientjes
2009-07-10 9:38 ` Nick Piggin
2009-07-10 18:55 ` Christoph Lameter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090710103025.GK14666@wotan.suse.de \
--to=npiggin@suse.de \
--cc=cl@linux-foundation.org \
--cc=fche@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=penberg@cs.helsinki.fi \
--cc=rientjes@google.com \
--cc=vegard.nossum@gmail.com \
--cc=yuan-bo.ye@motorola.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox