From: Jamie Lokier <jamie@shareable.org>
To: "Kirill A. Shutemov" <kirill@shutemov.name>
Cc: ARM Linux Mailing List <linux-arm-kernel@lists.arm.linux.org.uk>,
linux-kernel@vger.kernel.org,
Siarhei Siamashka <siarhei.siamashka@nokia.com>
Subject: Re: [PATCH] ARM: copy_page.S: take into account the size of the cache line
Date: Sat, 11 Jul 2009 00:51:23 +0100 [thread overview]
Message-ID: <20090710235123.GE30322@shareable.org> (raw)
In-Reply-To: <1247156605-16245-1-git-send-email-kirill@shutemov.name>
Kirill A. Shutemov wrote:
> From: Kirill A. Shutemov <kirill@shutemov.name>
>
> Optimized version of copy_page() was written with assumption that cache
> line size is 32 bytes. On Cortex-A8 cache line size is 64 bytes.
>
> This patch tries to generalize copy_page() to work with any cache line
> size if cache line size is multiple of 16 and page size is multiple of
> two cache line size.
>
> Unfortunately, kernel doesn't provide a macros with correct cache size.
> L1_CACHE_SHIFT is 5 on any ARM. So we have to define macros for this
> propose by ourself.
Why don't you fix L1_CACHE_SHIFT for Cortex-A8?
-- Jamie
next prev parent reply other threads:[~2009-07-10 23:51 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-07-09 16:23 [PATCH] ARM: copy_page.S: take into account the size of the cache line Kirill A. Shutemov
2009-07-10 23:51 ` Jamie Lokier [this message]
2009-07-15 13:12 ` Siarhei Siamashka
2009-07-15 13:55 ` Russell King - ARM Linux
-- strict thread matches above, loose matches on Subject: below --
2009-09-02 13:24 [PATCH 2/2] " Russell King - ARM Linux
2009-09-02 17:19 ` [PATCH] " Kirill A. Shutemov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090710235123.GE30322@shareable.org \
--to=jamie@shareable.org \
--cc=kirill@shutemov.name \
--cc=linux-arm-kernel@lists.arm.linux.org.uk \
--cc=linux-kernel@vger.kernel.org \
--cc=siarhei.siamashka@nokia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox