From: Ingo Molnar <mingo@elte.hu>
To: Roland Dreier <roland@digitalvampire.org>
Cc: Linus Torvalds <torvalds@linux-foundation.org>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] x86: Remove spurious printk level from segfault message
Date: Sat, 11 Jul 2009 09:57:21 +0200 [thread overview]
Message-ID: <20090711075721.GA8295@elte.hu> (raw)
In-Reply-To: <874otjitkj.fsf@shaolin.home.digitalvampire.org>
* Roland Dreier <roland@digitalvampire.org> wrote:
> Since commit 5fd29d6c ("printk: clean up handling of log-levels and
> newlines"), the kernel logs segfaults like:
>
> <6>gnome-power-man[24509]: segfault at 20 ip 00007f9d4950465a sp 00007fffbb50fc70 error 4 in libgobject-2.0.so.0.2103.0[7f9d494f7000+45000]
>
> with the extra "<6>" being KERN_INFO. This happens because the printk
> in show_signal_msg() started with KERN_CONT and then used "%s" to pass
> in the real level; and KERN_CONT is no longer an empty string, and
> printk only pays attention to the level at the very beginning of the
> format string.
>
> Therefore, remove the KERN_CONT from this printk, since it is now
> actively causing problems (and never really made any sense).
Indeed, this particular KERN_CONT never made any sense. It's good it
has some active role now. Applied to tip:x86/urgent, thanks Roland.
Ingo
next prev parent reply other threads:[~2009-07-11 7:57 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-07-11 7:10 [PATCH] x86: Remove spurious printk level from segfault message Roland Dreier
2009-07-11 7:57 ` Ingo Molnar [this message]
2009-07-11 8:01 ` [tip:x86/urgent] " tip-bot for Roland Dreier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090711075721.GA8295@elte.hu \
--to=mingo@elte.hu \
--cc=linux-kernel@vger.kernel.org \
--cc=roland@digitalvampire.org \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox