From: Greg KH <gregkh@suse.de>
To: Jiri Slaby <jirislaby@gmail.com>
Cc: Julia Lawall <julia@diku.dk>,
devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org,
kernel-janitors@vger.kernel.org
Subject: Re: [PATCH 5/5] staging/otus: Move a dereference below a NULL test
Date: Sat, 11 Jul 2009 10:03:56 -0700 [thread overview]
Message-ID: <20090711170356.GA5205@suse.de> (raw)
In-Reply-To: <4A584A94.5010105@gmail.com>
On Sat, Jul 11, 2009 at 10:17:24AM +0200, Jiri Slaby wrote:
> On 07/11/2009 09:51 AM, Julia Lawall wrote:
> > diff -u -p a/drivers/staging/otus/wwrap.c b/drivers/staging/otus/wwrap.c
> > --- a/drivers/staging/otus/wwrap.c
> > +++ b/drivers/staging/otus/wwrap.c
> > @@ -1016,12 +1016,13 @@ void kevent(struct work_struct *work)
> > {
> > struct usbdrv_private *macp =
> > container_of(work, struct usbdrv_private, kevent);
> > - zdev_t *dev = macp->device;
> > + zdev_t *dev;
> >
> > if (macp == NULL)
> > {
> > return;
> > }
>
> The test is rather useless here.
Yes it is.
Julia, if you just remove the NULL check, will that keep your scripts
happy from noticing such a "problem"?
thanks,
greg k-h
next prev parent reply other threads:[~2009-07-11 17:24 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-07-11 7:51 [PATCH 5/5] staging/otus: Move a dereference below a NULL test Julia Lawall
2009-07-11 8:17 ` Jiri Slaby
2009-07-11 8:31 ` Julia Lawall
2009-07-11 10:17 ` Jaswinder Singh Rajput
2009-07-11 10:32 ` Jaswinder Singh Rajput
2009-07-11 11:09 ` Jiri Slaby
2009-07-13 17:00 ` Luis R. Rodriguez
2009-07-11 11:06 ` Jiri Slaby
2009-07-11 11:32 ` Julia Lawall
2009-07-11 11:58 ` Julia Lawall
2009-07-11 17:03 ` Greg KH [this message]
2009-07-11 18:28 ` Julia Lawall
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090711170356.GA5205@suse.de \
--to=gregkh@suse.de \
--cc=devel@driverdev.osuosl.org \
--cc=jirislaby@gmail.com \
--cc=julia@diku.dk \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox