public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Sergey Senozhatsky <sergey.senozhatsky@mail.by>
To: Alan Cox <alan@lxorguk.ukuu.org.uk>
Cc: Andrew Morton <akpm@linux-foundation.org>, linux-kernel@vger.kernel.org
Subject: Re: possible regression with pty.c commit
Date: Sun, 12 Jul 2009 02:55:30 +0300	[thread overview]
Message-ID: <20090711235530.GA3231@localdomain.by> (raw)
In-Reply-To: <20090711232452.4dc7c1ba@lxorguk.ukuu.org.uk>

[-- Attachment #1: Type: text/plain, Size: 1093 bytes --]

On (07/11/09 23:24), Alan Cox wrote:
> On Sat, 11 Jul 2009 22:15:56 +0300
> Sergey Senozhatsky <sergey.senozhatsky@mail.by> wrote:
> 
> > Hello,
> > commit d945cb9cce20ac7143c2de8d88b187f62db99bdc ("pty: Rework the pty layer to use the normal buffering logic")
> > seems to brake kdesu.
> 
> This looks like a timing bug in kdesu at first glance but it may be more
> complex.
> 
> > close(11)                               = 0
> 
> We close one side of the pty/tty pair
> 
> > write(10, "stop", 4)                    = 4
> > write(10, "\n", 1)                      = 1
> > fcntl64(10, F_GETFL)                    = 0x2 (flags O_RDWR)
> > read(10, 0xbf840858, 255)               = -1 EIO (Input/output error)		<<<<<<<<<
> 
> At this point the other side is closed, we have a hangup and the read
> correctly I think gets -EIO.
> 
> I will have a look at kdesu on Monday, I've got Fedora setups here so
> hopefully I can reproduce it simply.
> 

Alan, I forgot to tell - I'm using KDE 3.5.9 (3.5.10). Don't know whether this can be reproduced with KDE 4.x.x.

	Sergey

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 315 bytes --]

  reply	other threads:[~2009-07-11 23:53 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-07-11 19:15 possible regression with pty.c commit Sergey Senozhatsky
2009-07-11 22:24 ` Alan Cox
2009-07-11 23:55   ` Sergey Senozhatsky [this message]
2009-07-13 11:48     ` Alan Cox
2009-07-13 16:41       ` Sergey Senozhatsky
2009-07-14 16:28       ` Sergey Senozhatsky
2009-07-14 22:57         ` Pierre Willenbrock
2009-07-15 10:05         ` Alan Cox
2009-07-15 10:27           ` Sergey Senozhatsky
2009-07-15 10:30             ` Alan Cox
2009-07-15 17:03               ` Sergey Senozhatsky
2009-07-17  0:51                 ` Dave Young
2009-07-17  8:34                   ` Sergey Senozhatsky
2009-07-17 13:34                     ` Dave Young
2009-07-19 23:07       ` Andreas Schwab

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20090711235530.GA3231@localdomain.by \
    --to=sergey.senozhatsky@mail.by \
    --cc=akpm@linux-foundation.org \
    --cc=alan@lxorguk.ukuu.org.uk \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox