From: Cyrill Gorcunov <gorcunov@gmail.com>
To: "Maciej W. Rozycki" <macro@linux-mips.org>
Cc: Ingo Molnar <mingo@elte.hu>, "H. Peter Anvin" <hpa@zytor.com>,
Thomas Gleixner <tglx@linutronix.de>,
Yinghai Lu <yinghai@kernel.org>,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: [RFC -tip] x86,apic - set cpu_has_apic for discrete apic
Date: Sun, 12 Jul 2009 10:34:45 +0400 [thread overview]
Message-ID: <20090712063445.GC4782@lenovo> (raw)
In-Reply-To: <alpine.LFD.2.00.0907120709220.13862@eddie.linux-mips.org>
[Maciej W. Rozycki - Sun, Jul 12, 2009 at 07:31:44AM +0100]
| On Sun, 12 Jul 2009, Cyrill Gorcunov wrote:
|
| > Well, I've been using code reading. No real hardware test.
| > I just don't have such a hardware.
|
| Then simulate it! Proofreading is not enough -- the APIC code is too
| twisted. Be imaginative -- for example you can clear the APIC bit at the
| time CPUID flags are saved for later use with cpu_has_apic() and see if
| the code behaves as expected. Sprinkle printk()s here and there to see if
| variables are set correctly, whether the right code paths are taken, etc.
| Tedious? Well, who said kernel debugging was going to be a piece of cake?
|
| Most of the APIC support code I have written has been run-time tested
| like this -- one change at a time. Do you think I have an infinite number
| of SMP configurations too? All the clean-ups I worked on last year were
| tested with one laptop. I didn't even have a serial port for console
| dumps back then.
|
| NAK from me until you've tested it, sorry.
Started to... hope to publish results today!
Thanks Maciej!
|
| Maciej
|
-- Cyrill
prev parent reply other threads:[~2009-07-12 6:34 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-07-11 21:29 [RFC -tip] x86,apic - set cpu_has_apic for discrete apic Cyrill Gorcunov
2009-07-12 0:41 ` Maciej W. Rozycki
2009-07-12 5:52 ` Cyrill Gorcunov
2009-07-12 6:31 ` Maciej W. Rozycki
2009-07-12 6:34 ` Cyrill Gorcunov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090712063445.GC4782@lenovo \
--to=gorcunov@gmail.com \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=macro@linux-mips.org \
--cc=mingo@elte.hu \
--cc=tglx@linutronix.de \
--cc=yinghai@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox