[PATCH] Fix markup_oops to work with 32-bit userspace on a 64-bit kernel

[PATCH] Fix markup_oops to work with 32-bit userspace on a 64-bit kernel

[Matthew Wilcox]

A 32-bit perl can't handle 64-bit addresses without using the BigInt package.

Signed-off-by: Matthew Wilcox <willy@linux.intel.com>

diff --git a/scripts/markup_oops.pl b/scripts/markup_oops.pl
index 528492b..8977401 100644
--- a/scripts/markup_oops.pl
+++ b/scripts/markup_oops.pl
@@ -1,6 +1,7 @@
 #!/usr/bin/perl
 
 use File::Basename;
+use Math::BigInt;
 
 # Copyright 2008, Intel Corporation
 #
@@ -172,8 +173,8 @@ while (<STDIN>) {
 	parse_x86_regs($line);
 }
 
-my $decodestart = hex($target) - hex($func_offset);
-my $decodestop = hex($target) + 8192;
+my $decodestart = Math::BigInt->from_hex("0x$target") - Math::BigInt->from_hex("0x$func_offset");
+my $decodestop = Math::BigInt->from_hex("0x$target") + 8192;
 if ($target eq "0") {
 	print "No oops found!\n";
 	print "Usage: \n";

-- 
Matthew Wilcox				Intel Open Source Technology Centre
"Bill, look, we understand that you're interested in selling us this
operating system, but compare it to ours.  We can't possibly take such
a retrograde step."

Re: [PATCH] Fix markup_oops to work with 32-bit userspace on a 64-bit kernel

[Arjan van de Ven]

On Mon, 13 Jul 2009 08:18:19 -0600
Matthew Wilcox <matthew@wil.cx> wrote:

> 
> A 32-bit perl can't handle 64-bit addresses without using the BigInt
> package.
> 
> Signed-off-by: Matthew Wilcox <willy@linux.intel.com>

looks sane enuogh to me


Acked-by: Arjan van de Ven <arjan@linux.intel.com>


Andrew, can you pull this into -mm patch-logistics wise please?


> 
> diff --git a/scripts/markup_oops.pl b/scripts/markup_oops.pl
> index 528492b..8977401 100644
> --- a/scripts/markup_oops.pl
> +++ b/scripts/markup_oops.pl
> @@ -1,6 +1,7 @@
>  #!/usr/bin/perl
>  
>  use File::Basename;
> +use Math::BigInt;
>  
>  # Copyright 2008, Intel Corporation
>  #
> @@ -172,8 +173,8 @@ while (<STDIN>) {
>  	parse_x86_regs($line);
>  }
>  
> -my $decodestart = hex($target) - hex($func_offset);
> -my $decodestop = hex($target) + 8192;
> +my $decodestart = Math::BigInt->from_hex("0x$target") -
> Math::BigInt->from_hex("0x$func_offset"); +my $decodestop =
> Math::BigInt->from_hex("0x$target") + 8192; if ($target eq "0") {
>  	print "No oops found!\n";
>  	print "Usage: \n";
> 


-- 
Arjan van de Ven 	Intel Open Source Technology Centre
For development, discussion and tips for power savings, 
visit http://www.lesswatts.org

Re: [PATCH] Fix markup_oops to work with 32-bit userspace on a 64-bit kernel

[Ozan Çağlayan]

Matthew Wilcox wrote On 13-07-2009 17:18:
> A 32-bit perl can't handle 64-bit addresses without using the BigInt package.
>
>  
> -my $decodestart = hex($target) - hex($func_offset);
> -my $decodestop = hex($target) + 8192;
> +my $decodestart = Math::BigInt->from_hex("0x$target") - Math::BigInt->from_hex("0x$func_offset");
> +my $decodestop = Math::BigInt->from_hex("0x$target") + 8192;
>  if ($target eq "0") {
>  	print "No oops found!\n";
>  	print "Usage: \n";
>   

$func_offset has already "0x" so this commit prepends another "0x"
causing decodestart to be NaN.

Regards,
Ozan