From: Russell King - ARM Linux <linux@arm.linux.org.uk>
To: Dirk Behme <dirk.behme@googlemail.com>
Cc: Catalin Marinas <catalin.marinas@arm.com>,
Sudeep K N <sudeepholla.maillist@gmail.com>,
linux-arm-kernel@lists.arm.linux.org.uk, drzeus-mmc@drzeus.cx,
linux-kernel@vger.kernel.org
Subject: Re: Rootfs in eMMC: Kernel panic ...Attempted to kill init!
Date: Mon, 13 Jul 2009 16:48:11 +0100 [thread overview]
Message-ID: <20090713154811.GA31979@n2100.arm.linux.org.uk> (raw)
In-Reply-To: <4A5B5640.2050308@googlemail.com>
On Mon, Jul 13, 2009 at 05:44:00PM +0200, Dirk Behme wrote:
> Hi Catalin,
>
> Catalin Marinas wrote:
>> On Mon, 2009-06-22 at 17:46 +0100, Russell King - ARM Linux wrote:
>>> On Mon, Jun 22, 2009 at 05:13:16PM +0100, Catalin Marinas wrote:
>>>> In my case (ext2 over pata_platform), there is no flush_dcache_page()
>>>> call after the page was written with data from the CompactFlash (neither
>>>> the driver nor the VFS layer do this and we used hardware tracing to
>>>> double-check). When the page is mapped into user space,
>>>> update_mmu_cache() is called but the page hasn't been marked as dirty
>>>> and no D-cache flushing occurs. Calling flush_dcache_page() in
>>>> mpage_end_io_read() works around this issue.
>>> As already covered, there's no chance of adding such a call to the
>>> generic kernel. It's the responsibility of the drivers to ensure that
>>> data they read in hits the underlying page - in the same way that DMA
>>> does.
>>
>> The patch below appears to solve the problem with CompactFlash using
>> pata_platform (I cc'ed linux-ide since the patch changes their code).
>> The patch only handles the read case but similarly it may need to handle
>> the write case if D-cache aliasing between user and kernel mappings
>> exists.
>>
>> For the USB mass storage, I haven't yet figured out the best place to
>> call flush_dcache_page().
>
> Any news regarding USB mass storage on ARM MPCore? Else this would mean
> that USB mass storage (USB stick, USB disk) formatted with ext2/3/4
> wouldn't work with MPCore?
USB normally uses DMA, so should be unaffected by this issue.
next prev parent reply other threads:[~2009-07-13 15:48 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-06-18 9:18 Rootfs in eMMC: Kernel panic ...Attempted to kill init! Sudeep K N
2009-06-19 13:44 ` Russell King - ARM Linux
2009-06-22 14:13 ` Sudeep K N
2009-06-22 14:26 ` Catalin Marinas
2009-06-22 14:32 ` Catalin Marinas
2009-06-22 15:43 ` Russell King - ARM Linux
2009-06-22 15:50 ` Catalin Marinas
2009-06-22 15:56 ` Russell King - ARM Linux
2009-06-22 16:13 ` Catalin Marinas
2009-06-22 16:46 ` Russell King - ARM Linux
2009-06-22 21:37 ` Catalin Marinas
2009-06-23 9:23 ` Linus Walleij
2009-06-23 14:34 ` Catalin Marinas
2009-07-13 15:44 ` Dirk Behme
2009-07-13 15:48 ` Russell King - ARM Linux [this message]
2009-07-16 10:39 ` Catalin Marinas
2009-06-23 5:58 ` Sudeep K N
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090713154811.GA31979@n2100.arm.linux.org.uk \
--to=linux@arm.linux.org.uk \
--cc=catalin.marinas@arm.com \
--cc=dirk.behme@googlemail.com \
--cc=drzeus-mmc@drzeus.cx \
--cc=linux-arm-kernel@lists.arm.linux.org.uk \
--cc=linux-kernel@vger.kernel.org \
--cc=sudeepholla.maillist@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox