From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756616AbZGMRAl (ORCPT ); Mon, 13 Jul 2009 13:00:41 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1756596AbZGMRAk (ORCPT ); Mon, 13 Jul 2009 13:00:40 -0400 Received: from mail.atheros.com ([12.36.123.2]:10263 "EHLO mail.atheros.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755614AbZGMRAk (ORCPT ); Mon, 13 Jul 2009 13:00:40 -0400 Date: Mon, 13 Jul 2009 10:00:38 -0700 From: "Luis R. Rodriguez" To: Jiri Slaby CC: Jaswinder Singh Rajput , Luis Rodriguez , Julia Lawall , "gregkh@suse.de" , "devel@driverdev.osuosl.org" , "linux-kernel@vger.kernel.org" , "kernel-janitors@vger.kernel.org" Subject: Re: [PATCH 5/5] staging/otus: Move a dereference below a NULL test Message-ID: <20090713170038.GA12919@mosca> References: <4A584A94.5010105@gmail.com> <1247307444.3032.2.camel@hpdv5.satnam> <1247308323.3032.5.camel@hpdv5.satnam> <4A5872FD.8040500@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <4A5872FD.8040500@gmail.com> User-Agent: Mutt/1.5.20 (2009-06-14) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, Jul 11, 2009 at 04:09:49AM -0700, Jiri Slaby wrote: > On 07/11/2009 12:32 PM, Jaswinder Singh Rajput wrote: > > And more funny thing is that all functions are global in this file. > > > > Greg, can you please check the scope of these function, why all are > > global. > > Why don't you do that? I think patches are welcome :). I will note Otus has a replacement ar9170 driver already upstream, as soon as it gets aggregation support otus will be dropped. Better focus on ar9170 instead if you are looking to spend some cycles on driver help. Luis