Re: HTC: touchscreen driver

[Pavel Machek <pavel@ucw.cz>]

On Mon 2009-07-13 18:29:52, Arve Hj?nnev?g wrote:
> On Mon, Jul 13, 2009 at 3:07 PM, Pavel Machek<pavel@ucw.cz> wrote:
> > On Mon 2009-07-13 22:57:49, Pavel Machek wrote:
> >> Hi!
> >>
> >> I'm looking at synaptic touchscreen driver... who should be listed as
> >> an author?
> >>
> >> Changes I have so far are...
> >>
> >> checkpatch only has minor complains -- lines over 80 characters -- but
> >> the code is _way_ too deeply nested with way too little functions.
> >
> > Here's better cleanup. But... some functions are still _way_ too big.
> >
> > Signed-off-by: Pavel Machek <pavel@ucw.cz>
> > diff --git a/drivers/input/touchscreen/Kconfig b/drivers/input/touchscreen/Kconfig
> > index 339083e..fa3404f 100644
> > --- a/drivers/input/touchscreen/Kconfig
> > +++ b/drivers/input/touchscreen/Kconfig
> > @@ -94,6 +94,9 @@ config TOUCHSCREEN_GUNZE
> >  config TOUCHSCREEN_ELAN_I2C_8232
> >        tristate "Elan 8232 I2C touchscreen"
> >        depends on I2C
> > +       help
> > +         This enables support for Elan over I2C based touchscreens.
> > +         Such touchscreen is used in HTC Dream.
> >
> 
> Why is this here? This driver is not related to elan touchscreens.

I forgot to strip it. Can you apply it to linux-msm tree so that it does
not get lost? 

> >  static struct workqueue_struct *synaptics_wq;
> >
> >  struct synaptics_ts_data {
> > -       uint16_t addr;
> > +       u16 addr;
> 
> What is the point of this change?

u16 is both shorter and more common in kernel, so use that.

									Pavel

-- 
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html