Re: [PATCH 1/3] backlight: Allow drivers to update the core, and generate events on changes

[Matthew Garrett <mjg59@srcf.ucam.org>]

On Tue, Jul 14, 2009 at 01:29:33PM +0100, Richard Purdie wrote:

> My main concern is that we don't start getting bug reports of 'missing'
> events and have clearly defined expectations of when we see what kind of
> events. For example, should an event be emitted when low battery causes
> the backlight to be limited? How about console blanking events turning
> off the backlight? Are there any other occasions we should be emitting
> change events and do we need to audit other drivers?

These are all good questions. I'm working through the drivers now, and 
there's definitely a few more that need doing.

> Also, are "userspace" and "kernel" as meaningful as they could be? Would
> "sysfs" and "hwkeys" make more sense and allow for other future hardware
> differences? Perhaps someone will tie the backlight to an ambient light
> sensor for example...

Yes, though we'd need to extend the interface slightly in that case to 
allow the information to be provided. The ALS case is a good one - if 
that ends up happening in-kernel then there probably shouldn't be a 
UI update.

-- 
Matthew Garrett | mjg59@srcf.ucam.org