Re: HTC: touchscreen driver

[Pavel Machek <pavel@ucw.cz>]

Hi!

> >> >        if (!i2c_check_functionality(client->adapter, I2C_FUNC_I2C)) {
> >> >                printk(KERN_ERR "synaptics_ts_probe: need I2C_FUNC_I2C\n");
> >> > @@ -269,6 +354,9 @@ static int synaptics_ts_probe(
> >> >        pdata = client->dev.platform_data;
> >> >        if (pdata)
> >> >                ts->power = pdata->power;
> >> > +       else
> >> > +               pdata = kzalloc(sizeof(*pdata), GFP_KERNEL);
> >> > +
> >>
> >> Where do you free this?
> >
> > Well, nowhere; but it should not actually matter. ... btw can this
> > path (!pdata) actually trigger? The driver will not be working,
> > anyway, in that case..
> 
> The driver should work fine without the pdata. The pdata is used to
> align the touchscreen data with the screen behind it.

Ok...

> >> This driver only supports a subset of Synaptics' devices so a more
> >> generic driver will eventually be needed. The patch below adds support
> >> for a more recent but similar panel.
> >
> > Ok, that should be simple enough to apply, but lets do improvements
> > when we cleaned the code enough for the mainline...?
> 
> We need this change now. Your cleanup will cause conflicts for anyone
> using our driver, so it would be better if it includes all our fixes.

Well, I don't expect you to use the cleaned-up driver as-is: I had to
remove the wakelocks functionality as infrastructure is not in
mainline. (Plus, I do not have hardware to test your latest version).

Applying small patch on top of cleaned up driver should be better than
carrying whole driver itself, right?

[Alternatively... I can try to incorporate your change, but I'd need
your testing at that point.]
									Pavel
-- 
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html