From: Subrata Modak <subrata@linux.vnet.ibm.com>
To: Richard Purdie <rpurdie@rpsys.net>, Raphael Assenat <raph@8d.com>
Cc: Sachin P Sant <sachinp@linux.vnet.ibm.com>,
gregkh <gregkh@suse.de>, David Howells <dhowells@redhat.com>,
Subrata Modak <subrata@linux.vnet.ibm.com>,
Balbir Singh <balbir@linux.vnet.ibm.com>,
LKML <linux-kernel@vger.kernel.org>
Subject: [PATCH 03/06] Fix compilation warning for drivers/leds/leds_gpio.c
Date: Wed, 15 Jul 2009 07:49:37 +0530 [thread overview]
Message-ID: <20090715021934.4169.26505.sendpatchset@subratamodak.linux.ibm.com> (raw)
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1: Type: text/plain, Size: 1611 bytes --]
gcc 4.4.1 generates the following build warning on i386:
drivers/leds/leds-gpio.c:75: warning: ‘create_gpio_led’ defined but not used
drivers/leds/leds-gpio.c:126: warning: ‘delete_gpio_led’ defined but not used
drivers/leds/leds-gpio.c: In function ‘gpio_led_init’:
drivers/leds/leds-gpio.c:316: warning: ‘ret’ is used uninitialized in this function
Fix them as below:
Put the definitions of create_gpio_led() and delete_gpio_led()
inside
#ifdef CONFIG_LEDS_GPIO_PLATFORM
when you actually call them inside
#ifdef CONFIG_LEDS_GPIO_PLATFORM
And the remaining fix is inspired by David Howells fix few days back:
http://lkml.org/lkml/2009/7/9/109,
Signed-off-by: Subrata Modak<subrata@linux.vnet.ibm.com>,
---
--- a/drivers/leds/leds-gpio.c 2009-06-29 19:20:42.000000000 +0530
+++ b/drivers/leds/leds-gpio.c 2009-07-15 05:51:21.000000000 +0530
@@ -29,6 +29,7 @@ struct gpio_led_data {
unsigned long *delay_on, unsigned long *delay_off);
};
+#ifdef CONFIG_LEDS_GPIO_PLATFORM
static void gpio_led_work(struct work_struct *work)
{
struct gpio_led_data *led_dat =
@@ -132,7 +133,6 @@ static void delete_gpio_led(struct gpio_
gpio_free(led->gpio);
}
-#ifdef CONFIG_LEDS_GPIO_PLATFORM
static int __devinit gpio_led_probe(struct platform_device *pdev)
{
struct gpio_led_platform_data *pdata = pdev->dev.platform_data;
@@ -298,7 +298,7 @@ static struct of_platform_driver of_gpio
static int __init gpio_led_init(void)
{
- int ret;
+ int uninitialized_var(ret);
#ifdef CONFIG_LEDS_GPIO_PLATFORM
ret = platform_driver_register(&gpio_led_driver);
---
Regards--
Subrata
reply other threads:[~2009-07-15 2:19 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090715021934.4169.26505.sendpatchset@subratamodak.linux.ibm.com \
--to=subrata@linux.vnet.ibm.com \
--cc=balbir@linux.vnet.ibm.com \
--cc=dhowells@redhat.com \
--cc=gregkh@suse.de \
--cc=linux-kernel@vger.kernel.org \
--cc=raph@8d.com \
--cc=rpurdie@rpsys.net \
--cc=sachinp@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox