From: Subrata Modak <subrata@linux.vnet.ibm.com>
To: Pau Oliva Fora <pof@eslack.org>, linux-input@vger.kernel.org
Cc: Sachin P Sant <sachinp@linux.vnet.ibm.com>,
David Howells <dhowells@redhat.com>,
Subrata Modak <subrata@linux.vnet.ibm.com>,
Balbir Singh <balbir@linux.vnet.ibm.com>,
LKML <linux-kernel@vger.kernel.org>
Subject: [PATCH 04/06] Fix compilation warning for drivers/input/touchscreen/htcpen.c
Date: Wed, 15 Jul 2009 07:50:08 +0530 [thread overview]
Message-ID: <20090715022005.4244.67703.sendpatchset@subratamodak.linux.ibm.com> (raw)
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1: Type: text/plain, Size: 768 bytes --]
gcc 4.4.1 generates the following build warning on i386:
CC drivers/input/touchscreen/htcpen.o
drivers/input/touchscreen/htcpen.c:50: warning: ‘pnp_ids’ defined but not used
Fix this by removing the static keyword when you are actually
exporting that structure.
Signed-off-by: Subrata Modak<subrata@linux.vnet.ibm.com>,
---
--- a/drivers/input/touchscreen/htcpen.c 2009-05-20 10:40:54.000000000 +0530
+++ b/drivers/input/touchscreen/htcpen.c 2009-07-15 06:15:34.000000000 +0530
@@ -47,7 +47,7 @@ static int invert_y;
module_param(invert_y, bool, 0644);
MODULE_PARM_DESC(invert_y, "If set, Y axis is inverted");
-static struct pnp_device_id pnp_ids[] = {
+struct pnp_device_id pnp_ids[] = {
{ .id = "PNP0cc0" },
{ .id = "" }
};
---
Regards--
Subrata
reply other threads:[~2009-07-15 2:20 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090715022005.4244.67703.sendpatchset@subratamodak.linux.ibm.com \
--to=subrata@linux.vnet.ibm.com \
--cc=balbir@linux.vnet.ibm.com \
--cc=dhowells@redhat.com \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=pof@eslack.org \
--cc=sachinp@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox