Re: [PATCH 01/06] Fix compilation warning for sound/soc/codecs/wm8400.c

Jaswinder Singh Rajput
2009-07-15T04:44:32Z

Hello Subrata,

On Wed, 2009-07-15 at 07:48 +0530, Subrata Modak wrote:
> Following fix is inspired by David Howells fix few days back:
> http://lkml.org/lkml/2009/7/9/109,
>

Please check further of this thread :

http://marc.info/?l=linux-kernel&m=124756210124518&w=2

> Signed-off-by: Subrata Modak<subrata@linux.vnet.ibm.com>,
> ---
>
> --- a/sound/soc/codecs/wm8400.c 2009-06-15 07:52:31.000000000 +0530
> +++ b/sound/soc/codecs/wm8400.c 2009-07-15 05:35:00.000000000 +0530
> @@ -1015,7 +1015,7 @@ static int wm8400_set_dai_pll(struct snd
> {
> struct snd_soc_codec *codec = codec_dai->codec;
> struct wm8400_priv *wm8400 = codec->private_data;
> - struct fll_factors factors;
> + struct fll_factors uninitialized_var(factors);
> int ret;
> u16 reg;
>
>

This kind of warnings born due to not handling the variables properly.
Please try to understand the root cause of this warning, just shutting
this warning is of no use.

Please revise your patches, If you face any problems let me know.

Thanks,
--
JSR