public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Anton Blanchard <anton@samba.org>
To: a.p.zijlstra@chello.nl, mingo@elte.hu, paulus@samba.org,
	fweisbec@gmail.com
Cc: linux-kernel@vger.kernel.org
Subject: [patch 3/5] perf_counter: Log vfork as a fork event
Date: Thu, 16 Jul 2009 20:42:50 +1000	[thread overview]
Message-ID: <20090716104817.589309391@samba.org> (raw)
In-Reply-To: 20090716104247.536695580@samba.org

Right now we don't output vfork events. Even though we should always see an
exec after a vfork, we may get perfcounter samples between the vfork and exec.
These samples can lead to some confusion when parsing perfcounter data.

To keep things consistent we should always log a fork event. It will result
in a little more log data, but is less confusing to trace parsing tools.

Signed-off-by: Anton Blanchard <anton@samba.org>
---

It took me a while to realise this wasn't a bug in some trace parsing
code I wrote, or an issue with samples being dropped :)

Index: linux.trees.git/kernel/fork.c
===================================================================
--- linux.trees.git.orig/kernel/fork.c	2009-07-15 10:00:30.000000000 +1000
+++ linux.trees.git/kernel/fork.c	2009-07-15 10:01:28.000000000 +1000
@@ -1407,14 +1407,11 @@
 		if (clone_flags & CLONE_VFORK) {
 			p->vfork_done = &vfork;
 			init_completion(&vfork);
-		} else if (!(clone_flags & CLONE_VM)) {
-			/*
-			 * vfork will do an exec which will call
-			 * set_task_comm()
-			 */
-			perf_counter_fork(p);
 		}
 
+		if (!(clone_flags & CLONE_THREAD))
+			perf_counter_fork(p);
+
 		audit_finish_fork(p);
 		tracehook_report_clone(regs, clone_flags, nr, p);
 

-- 


  parent reply	other threads:[~2009-07-16 10:56 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-07-16 10:42 [patch 0/5] Various perfcounter fixes Anton Blanchard
2009-07-16 10:42 ` [patch 1/5] perf_counter: Make sure we dont leak kernel memory to userspace Anton Blanchard
2009-07-18  9:50   ` [tip:perfcounters/urgent] " tip-bot for Anton Blanchard
2009-07-16 10:42 ` [patch 2/5] perf_counter: Synthesize VDSO mmap event Anton Blanchard
2009-07-18  9:50   ` [tip:perfcounters/urgent] " tip-bot for Anton Blanchard
2009-07-16 10:42 ` Anton Blanchard [this message]
2009-07-18  9:50   ` [tip:perfcounters/urgent] perf_counter: Log vfork as a fork event tip-bot for Anton Blanchard
2009-07-16 10:42 ` [patch 4/5] perf_counter: Add perf record option to log addresses Anton Blanchard
2009-07-18  9:50   ` [tip:perfcounters/urgent] " tip-bot for Anton Blanchard
2009-07-16 10:42 ` [patch 5/5] perf_counter: Make call graph option consistent Anton Blanchard
2009-07-16 14:49   ` Frederic Weisbecker
2009-07-18  9:50   ` [tip:perfcounters/urgent] " tip-bot for Anton Blanchard
2009-07-16 14:16 ` [patch 0/5] Various perfcounter fixes Peter Zijlstra

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20090716104817.589309391@samba.org \
    --to=anton@samba.org \
    --cc=a.p.zijlstra@chello.nl \
    --cc=fweisbec@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@elte.hu \
    --cc=paulus@samba.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox