public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Anton Blanchard <anton@samba.org>
To: a.p.zijlstra@chello.nl, mingo@elte.hu, paulus@samba.org,
	fweisbec@gmail.com
Cc: linux-kernel@vger.kernel.org
Subject: [patch 5/5] perf_counter: Make call graph option consistent
Date: Thu, 16 Jul 2009 20:42:52 +1000	[thread overview]
Message-ID: <20090716104817.803604373@samba.org> (raw)
In-Reply-To: 20090716104247.536695580@samba.org

perf record uses -g for logging call graph data but perf report uses -c
to print call graph data. Be consistent and use -g everywhere for call graph
data.

Also update the help text to reflect the current default - fractal,0.5

Signed-off-by: Anton Blanchard <anton@samba.org>
---

Im not sure if it's too late to make this change, but I've tripped
up a number of times when I cycle between perf record and perf report.

Index: linux.trees.git/tools/perf/builtin-report.c
===================================================================
--- linux.trees.git.orig/tools/perf/builtin-report.c	2009-07-16 19:41:41.000000000 +1000
+++ linux.trees.git/tools/perf/builtin-report.c	2009-07-16 19:41:49.000000000 +1000
@@ -2005,9 +2005,9 @@
 		   "regex filter to identify parent, see: '--sort parent'"),
 	OPT_BOOLEAN('x', "exclude-other", &exclude_other,
 		    "Only display entries with parent-match"),
-	OPT_CALLBACK_DEFAULT('c', "callchain", NULL, "output_type,min_percent",
+	OPT_CALLBACK_DEFAULT('g', "call-graph", NULL, "output_type,min_percent",
 		     "Display callchains using output_type and min percent threshold. "
-		     "Default: flat,0", &parse_callchain_opt, callchain_default_opt),
+		     "Default: fractal,0.5", &parse_callchain_opt, callchain_default_opt),
 	OPT_STRING('d', "dsos", &dso_list_str, "dso[,dso...]",
 		   "only consider symbols in these dsos"),
 	OPT_STRING('C', "comms", &comm_list_str, "comm[,comm...]",

-- 


  parent reply	other threads:[~2009-07-16 10:54 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-07-16 10:42 [patch 0/5] Various perfcounter fixes Anton Blanchard
2009-07-16 10:42 ` [patch 1/5] perf_counter: Make sure we dont leak kernel memory to userspace Anton Blanchard
2009-07-18  9:50   ` [tip:perfcounters/urgent] " tip-bot for Anton Blanchard
2009-07-16 10:42 ` [patch 2/5] perf_counter: Synthesize VDSO mmap event Anton Blanchard
2009-07-18  9:50   ` [tip:perfcounters/urgent] " tip-bot for Anton Blanchard
2009-07-16 10:42 ` [patch 3/5] perf_counter: Log vfork as a fork event Anton Blanchard
2009-07-18  9:50   ` [tip:perfcounters/urgent] " tip-bot for Anton Blanchard
2009-07-16 10:42 ` [patch 4/5] perf_counter: Add perf record option to log addresses Anton Blanchard
2009-07-18  9:50   ` [tip:perfcounters/urgent] " tip-bot for Anton Blanchard
2009-07-16 10:42 ` Anton Blanchard [this message]
2009-07-16 14:49   ` [patch 5/5] perf_counter: Make call graph option consistent Frederic Weisbecker
2009-07-18  9:50   ` [tip:perfcounters/urgent] " tip-bot for Anton Blanchard
2009-07-16 14:16 ` [patch 0/5] Various perfcounter fixes Peter Zijlstra

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20090716104817.803604373@samba.org \
    --to=anton@samba.org \
    --cc=a.p.zijlstra@chello.nl \
    --cc=fweisbec@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@elte.hu \
    --cc=paulus@samba.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox