Re: [PATCH] [x86, msr]: remove code duplication

H. Peter Anvin
2009-07-06T21:32:39Z

Borislav Petkov wrote:
> -
> - smp_call_function_many(mask, __rdmsr_on_cpu, &rv, 1);
> + smp_call_function_single(this_cpu, msr_func, &rv, 1);
> + smp_call_function_many(mask, msr_func, &rv, 1);
> preempt_enable();

Why are you using smp_call_function_single() to execute something *on
your own CPU*?

-hpa