public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Denys Vlasenko <vda.linux@googlemail.com>
To: Valdis.Kletnieks@vt.edu
Cc: Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] add "VmUsers: N" to /proc/$PID/status
Date: Thu, 16 Jul 2009 23:27:25 +0200	[thread overview]
Message-ID: <200907162327.25700.vda.linux@googlemail.com> (raw)
In-Reply-To: <48286.1247773600@turing-police.cc.vt.edu>

On Thursday 16 July 2009 21:46, Valdis.Kletnieks@vt.edu wrote:
> On Wed, 15 Jul 2009 03:22:18 +0200, Denys Vlasenko said:
> 
> > It can be nice to know how many such CLONE_VM'ed processes
> > share VM with given /proc/PID. Then it would be possible to do
> > more accurate accounting of memory usage. Say, by dividing
> > all memory usage numbers of this process by this number.
> 
> Process A clones a process A1.  Process B clones a process B1. Now
> all 4 of them have 'VmUsers: 2' on them, but there's no clean way to tell
> whether A1 or B1 is the one sharing with A, or with B.
> 
> The patch is probably sufficient if all you want is some N to divide by, but
> not if you care *which* processes are sharing how much.

You are right. There is more: the truly accurate accounting
needs to be per page. Like /proc/$PID/smaps
and /proc/$PID/pagemap. (However, I am not sure you can
relize that two processes share a VM by looking
at these files either)

I do not aim to solve _that_ problem with my patch.

I, indeed, want to have just an N I can divide RSS/VSZ/etc by,
to get, say, top display which do not mislead user
into thinking that he has 3 processes with 100 megabyte RSS
when in reality he has 3 processes sharing a single VM
with 100 meg RSS.

This will still not be completely accurate due to per-page
sharing and such, but it will be more accurate
than what we have now.
--
vda

  reply	other threads:[~2009-07-16 21:27 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-07-15  1:22 [PATCH] add "VmUsers: N" to /proc/$PID/status Denys Vlasenko
2009-07-16 19:46 ` Valdis.Kletnieks
2009-07-16 21:27   ` Denys Vlasenko [this message]
2009-07-16 23:24     ` Valdis.Kletnieks
2009-07-16 23:44       ` Denys Vlasenko

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200907162327.25700.vda.linux@googlemail.com \
    --to=vda.linux@googlemail.com \
    --cc=Valdis.Kletnieks@vt.edu \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox