From: Pavel Machek <pavel@ucw.cz>
To: Greg KH <greg@kroah.com>
Cc: swetland@google.com, malchev@google.com,
kernel list <linux-kernel@vger.kernel.org>
Subject: Re: HTC Dream: qdsp support for staging
Date: Fri, 17 Jul 2009 03:01:57 +0200 [thread overview]
Message-ID: <20090717010157.GA2002@elf.ucw.cz> (raw)
In-Reply-To: <20090716230042.GB3609@kroah.com>
On Thu 2009-07-16 16:00:42, Greg KH wrote:
> On Fri, Jul 10, 2009 at 10:37:10AM +0200, Pavel Machek wrote:
> > From: Iliyan Malchev <ibm@android.com>
> >
> > QDSP code is neccessarry for communication with some hardware
> > components on HTC Dream, including camera hardware. It also drives DSP
> > coproccessor.
> >
> > Signed-off-by: Pavel Machek <pavel@ucw.cz>
>
> Please don't compress patches :(
I had to -- in order to fit to lkml maillist limits.
> Your patch didn't have any way to actually build the code, care to
> respin it and add the proper Kconfig and Makefile hooks?
Well, resending 100K+ patch to get 3 missing lines is somewhat
"interesting"... and the problem is that proper Kconfig/Makefile hooks
actually depend on order in which you apply the patches.
Would it be possible to just apply the 3 patches, with me supplying
Kconfig/Makefile hooks in patch #4? That's sometimes used to
aid bisectability, and it would save me quite a lot of work (and
possible mistakes) that way.
[I'd hate to set up quilt just to get 3 lines in Makefile into the
right series of 3 patches, and if I do it by hand there's chance of
mistakes...]
Pavel
--
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
next prev parent reply other threads:[~2009-07-17 1:02 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-07-10 8:37 HTC Dream: qdsp support for staging Pavel Machek
2009-07-10 17:25 ` Daniel Walker
2009-07-11 23:05 ` Pavel Machek
2009-07-11 23:56 ` Daniel Walker
2009-07-12 10:28 ` Pavel Machek
2009-07-16 23:00 ` Greg KH
2009-07-17 1:01 ` Pavel Machek [this message]
2009-07-17 1:12 ` Greg KH
2009-07-17 11:30 ` Pavel Machek
2009-07-17 12:06 ` HTC Dream " Pavel Machek
2009-07-17 13:46 ` Greg KH
2009-07-17 13:57 ` Pavel Machek
2009-07-17 14:14 ` Greg KH
2009-07-18 10:41 ` Pavel Machek
2009-07-18 13:53 ` Daniel Walker
2009-07-18 15:04 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090717010157.GA2002@elf.ucw.cz \
--to=pavel@ucw.cz \
--cc=greg@kroah.com \
--cc=linux-kernel@vger.kernel.org \
--cc=malchev@google.com \
--cc=swetland@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox