From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933856AbZGQBCG (ORCPT ); Thu, 16 Jul 2009 21:02:06 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S933390AbZGQBCF (ORCPT ); Thu, 16 Jul 2009 21:02:05 -0400 Received: from atrey.karlin.mff.cuni.cz ([195.113.26.193]:41532 "EHLO atrey.karlin.mff.cuni.cz" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933141AbZGQBCF (ORCPT ); Thu, 16 Jul 2009 21:02:05 -0400 Date: Fri, 17 Jul 2009 03:01:57 +0200 From: Pavel Machek To: Greg KH Cc: swetland@google.com, malchev@google.com, kernel list Subject: Re: HTC Dream: qdsp support for staging Message-ID: <20090717010157.GA2002@elf.ucw.cz> References: <20090710083709.GA6418@elf.ucw.cz> <20090716230042.GB3609@kroah.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20090716230042.GB3609@kroah.com> X-Warning: Reading this can be dangerous to your mental health. User-Agent: Mutt/1.5.18 (2008-05-17) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu 2009-07-16 16:00:42, Greg KH wrote: > On Fri, Jul 10, 2009 at 10:37:10AM +0200, Pavel Machek wrote: > > From: Iliyan Malchev > > > > QDSP code is neccessarry for communication with some hardware > > components on HTC Dream, including camera hardware. It also drives DSP > > coproccessor. > > > > Signed-off-by: Pavel Machek > > Please don't compress patches :( I had to -- in order to fit to lkml maillist limits. > Your patch didn't have any way to actually build the code, care to > respin it and add the proper Kconfig and Makefile hooks? Well, resending 100K+ patch to get 3 missing lines is somewhat "interesting"... and the problem is that proper Kconfig/Makefile hooks actually depend on order in which you apply the patches. Would it be possible to just apply the 3 patches, with me supplying Kconfig/Makefile hooks in patch #4? That's sometimes used to aid bisectability, and it would save me quite a lot of work (and possible mistakes) that way. [I'd hate to set up quilt just to get 3 lines in Makefile into the right series of 3 patches, and if I do it by hand there's chance of mistakes...] Pavel -- (english) http://www.livejournal.com/~pavelmachek (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html