From: Mark Brown <broonie@opensource.wolfsonmicro.com>
To: Jean Delvare <khali@linux-fr.org>
Cc: Samuel Ortiz <sameo@linux.intel.com>,
Jonathan Cameron <jic23@cam.ac.uk>,
linux-kernel@vger.kernel.org, lm-sensors@lm-sensors.org
Subject: Re: [PATCH] hwmon: Add WM835x PMIC hardware monitoring driver
Date: Sat, 18 Jul 2009 11:47:48 +0100 [thread overview]
Message-ID: <20090718104747.GA11121@opensource.wolfsonmicro.com> (raw)
In-Reply-To: <20090718123951.34c776ca@hyperion.delvare>
On Sat, Jul 18, 2009 at 12:39:51PM +0200, Jean Delvare wrote:
> On Sat, 18 Jul 2009 10:59:17 +0100, Mark Brown wrote:
> > The reason it's formatted like that is that the AUXADC input names match
> > the names of the supplies that are being monitored so the second parameter
> > is also used to provide a label to userspace.
> This isn't how I read the code. I see a look-up table for labels, so the
> macro implementation is just a detail which shouldn't matter.
Oh, yes, you're right. Originally I'd implemented it the way I describe
but changed the code later - I'd forgotten that I'd done so when
replying to your mail.
I'll send a revised version out on Monday.
next prev parent reply other threads:[~2009-07-18 10:47 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-07-17 20:33 [PATCH] hwmon: Add WM835x PMIC hardware monitoring driver Mark Brown
2009-07-18 9:17 ` [lm-sensors] " Jean Delvare
2009-07-18 9:59 ` Mark Brown
2009-07-18 10:39 ` Jean Delvare
2009-07-18 10:47 ` Mark Brown [this message]
-- strict thread matches above, loose matches on Subject: below --
2009-07-20 11:43 Mark Brown
2009-07-20 13:19 ` Jean Delvare
2009-08-03 16:40 ` Samuel Ortiz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090718104747.GA11121@opensource.wolfsonmicro.com \
--to=broonie@opensource.wolfsonmicro.com \
--cc=jic23@cam.ac.uk \
--cc=khali@linux-fr.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lm-sensors@lm-sensors.org \
--cc=sameo@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox