From: Ingo Molnar <mingo@elte.hu>
To: Lai Jiangshan <laijs@cn.fujitsu.com>
Cc: Steven Rostedt <rostedt@goodmis.org>,
Frederic Weisbecker <fweisbec@gmail.com>,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH -tip] tracing: use defined fields to print formats
Date: Sat, 18 Jul 2009 13:29:28 +0200 [thread overview]
Message-ID: <20090718112928.GF27287@elte.hu> (raw)
In-Reply-To: <4A5F38F9.7060002@cn.fujitsu.com>
* Lai Jiangshan <laijs@cn.fujitsu.com> wrote:
> It seems that ftrace_format_##call() and
> ftrace_define_fields_##call() are duplicate more or less.
>
> trace_define_field() defines fields and links them into strcut
> ftrace_event_call. We reuse them to print formats and remove
> ftrace_format_##call(). It make all things simpler.
>
> TRACE_EVENT_FORMAT_NOFILTER is dropped. Because we should
> "trace_define_field()" fields for all struct ftrace_event_call,
> even it's no filter.
>
> Signed-off-by: Lai Jiangshan <laijs@cn.fujitsu.com>
> ---
> diff --git a/include/linux/ftrace_event.h b/include/linux/ftrace_event.h
> index 5c093ff..738b33d 100644
Minor request for future patches: could you please include the
diffstat all the time? Makes it much easier to see the general
impact of a patch.
Ingo
next prev parent reply other threads:[~2009-07-18 11:30 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-07-16 14:28 [PATCH -tip] tracing: use defined fields to print formats Lai Jiangshan
2009-07-18 11:29 ` Ingo Molnar [this message]
2009-07-20 17:26 ` Steven Rostedt
2009-07-21 1:09 ` Lai Jiangshan
2009-07-21 1:21 ` Steven Rostedt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090718112928.GF27287@elte.hu \
--to=mingo@elte.hu \
--cc=fweisbec@gmail.com \
--cc=laijs@cn.fujitsu.com \
--cc=linux-kernel@vger.kernel.org \
--cc=rostedt@goodmis.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox