From: Gleb Natapov <gleb@redhat.com>
To: Ingo Molnar <mingo@elte.hu>
Cc: Suresh Siddha <suresh.b.siddha@intel.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Sheng Yang <sheng@linux.intel.com>,
"kvm@vger.kernel.org" <kvm@vger.kernel.org>,
"avi@redhat.com" <avi@redhat.com>
Subject: Re: [PATCH] enable x2APIC without interrupt remapping under KVM
Date: Sun, 19 Jul 2009 19:40:59 +0300 [thread overview]
Message-ID: <20090719164059.GC14176@redhat.com> (raw)
In-Reply-To: <20090719162735.GB19434@elte.hu>
On Sun, Jul 19, 2009 at 06:27:35PM +0200, Ingo Molnar wrote:
>
> * Gleb Natapov <gleb@redhat.com> wrote:
>
> > + if (!ret) {
> > + /* IR is required if there is APIC ID > 255 even when running
> > + * under KVM
> > + */
>
> Eeek.
>
> > + if (x2apic_preenabled) {
> > + panic("x2apic enabled by bios. But IR enabling failed."
> > + " Check that CONFIG_X86_X2APIC and CONFIG_INTR_REMAP are"
> > + " enabled.");
>
> We dont want to break such messages mid-line, it makes it hard to
> git-grep for them. Also, the '. But' looks weird.
So what should I do? Make really long line?
--
Gleb.
next prev parent reply other threads:[~2009-07-19 16:41 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-07-19 11:44 [PATCH] enable x2APIC without interrupt remapping under KVM Gleb Natapov
2009-07-19 16:27 ` Ingo Molnar
2009-07-19 16:40 ` Gleb Natapov [this message]
2009-07-19 17:59 ` Ingo Molnar
-- strict thread matches above, loose matches on Subject: below --
2009-07-20 12:24 Gleb Natapov
2009-07-01 13:30 [PATCH v5] " Gleb Natapov
2009-07-01 21:00 ` Suresh Siddha
2009-07-03 8:29 ` Ingo Molnar
2009-07-05 14:32 ` [PATCH] " Gleb Natapov
2009-07-10 13:56 ` Ingo Molnar
2009-07-12 12:06 ` Gleb Natapov
2009-07-18 14:07 ` Ingo Molnar
2009-06-28 12:51 Gleb Natapov
2009-06-29 7:53 ` Sheng Yang
[not found] ` <200906291549.46581.sheng@linux.intel.com>
2009-06-29 8:12 ` Gleb Natapov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090719164059.GC14176@redhat.com \
--to=gleb@redhat.com \
--cc=avi@redhat.com \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=sheng@linux.intel.com \
--cc=suresh.b.siddha@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).