public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Robin Holt <holt@sgi.com>
To: Takashi Iwai <tiwai@suse.de>
Cc: Robin Holt <holt@sgi.com>, linux-kernel@vger.kernel.org
Subject: Re: Commit 1e137f92 broke my Vaio VGN-FE550G's hda_intel driver.
Date: Mon, 20 Jul 2009 07:26:23 -0500	[thread overview]
Message-ID: <20090720122623.GL6876@sgi.com> (raw)
In-Reply-To: <s5heisbc2rk.wl%tiwai@suse.de>

On Mon, Jul 20, 2009 at 08:00:31AM +0200, Takashi Iwai wrote:
> At Sun, 19 Jul 2009 17:55:38 -0500,
> Robin Holt wrote:
> > 
> > > What about to pass model=vaio?  Doesn't it work?
> > 
> > That didn't change the behavior.
> > 
> > > In anyways, please run alsa-info.sh with --no-upload option, and attach
> > > the generated file.
> > 
> > Here is the output from alsa-info.sh.  This was from the module load without
> > the model=vaio.  Below, (search for ---Robin---) is the output from alsa-info.sh
> > with model=vaio.
> 
> Thanks.  This look really like a bug.  The pin definition was wrongly
> placed.  It should have been before the pin overrides.
> 
> Could you try the patch below?  With the patch, the driver would work
> even without any model option.

Patch worked perfectly.

Acked-by: Robin Holt <holt@sgi.com>

Thanks,
Robin

  reply	other threads:[~2009-07-20 12:26 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-07-19 14:01 Commit 1e137f92 broke my Vaio VGN-FE550G's hda_intel driver Robin Holt
2009-07-19 16:04 ` Takashi Iwai
2009-07-19 22:55   ` Robin Holt
2009-07-20  6:00     ` Takashi Iwai
2009-07-20 12:26       ` Robin Holt [this message]
2009-07-20 13:14         ` Takashi Iwai
2009-07-20 13:40           ` Robin Holt
2009-07-20 13:41             ` Takashi Iwai

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20090720122623.GL6876@sgi.com \
    --to=holt@sgi.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=tiwai@suse.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox