From: Jean Delvare <khali@linux-fr.org>
To: Mark Brown <broonie@opensource.wolfsonmicro.com>
Cc: Samuel Ortiz <sameo@linux.intel.com>,
lm-sensors@lm-sensors.org, linux-kernel@vger.kernel.org,
Jonathan Cameron <jic23@cam.ac.uk>
Subject: Re: [PATCH] hwmon: Add WM835x PMIC hardware monitoring driver
Date: Mon, 20 Jul 2009 15:19:40 +0200 [thread overview]
Message-ID: <20090720151940.30bd38ca@hyperion.delvare> (raw)
In-Reply-To: <1248090225-16387-1-git-send-email-broonie@opensource.wolfsonmicro.com>
On Mon, 20 Jul 2009 12:43:45 +0100, Mark Brown wrote:
> This driver provides reporting of the status supply voltage rails
> of the WM835x series of PMICs via the hwmon API.
>
> Signed-off-by: Mark Brown <broonie@opensource.wolfsonmicro.com>
> ---
>
> This should address all the issues Jean raised:
> - Add a brief document to the hwmon directory.
> - Use full constant names as arguments for template macro.
> - Use DIV_ROUND_CLOSEST()
> - Set driver owner.
> - Fix typos.
>
> Thanks to Jonathan and Jean for their reviews.
>
> Documentation/hwmon/wm8350 | 26 +++++++
> drivers/hwmon/Kconfig | 10 +++
> drivers/hwmon/Makefile | 1 +
> drivers/hwmon/wm8350-hwmon.c | 151 +++++++++++++++++++++++++++++++++++++++
> drivers/mfd/wm8350-core.c | 3 +
> include/linux/mfd/wm8350/core.h | 6 ++
> 6 files changed, 197 insertions(+), 0 deletions(-)
> create mode 100644 Documentation/hwmon/wm8350
> create mode 100644 drivers/hwmon/wm8350-hwmon.c
Good work.
Acked-by: Jean Delvare <khali@linux-fr.org>
--
Jean Delvare
next prev parent reply other threads:[~2009-07-20 13:19 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-07-20 11:43 [PATCH] hwmon: Add WM835x PMIC hardware monitoring driver Mark Brown
2009-07-20 13:19 ` Jean Delvare [this message]
2009-08-03 16:40 ` Samuel Ortiz
-- strict thread matches above, loose matches on Subject: below --
2009-07-17 20:33 Mark Brown
2009-07-18 9:17 ` [lm-sensors] " Jean Delvare
2009-07-18 9:59 ` Mark Brown
2009-07-18 10:39 ` Jean Delvare
2009-07-18 10:47 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090720151940.30bd38ca@hyperion.delvare \
--to=khali@linux-fr.org \
--cc=broonie@opensource.wolfsonmicro.com \
--cc=jic23@cam.ac.uk \
--cc=linux-kernel@vger.kernel.org \
--cc=lm-sensors@lm-sensors.org \
--cc=sameo@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox