From: Greg KH <gregkh@suse.de>
To: Dave Jones <davej@redhat.com>,
Matthias Urlichs <smurf@smurf.noris.de>,
linux-kernel@vger.kernel.org, devel@driverdev.osuosl.org,
virtualization@lists.osdl.org,
Hank Janssen <hjanssen@microsoft.com>,
Haiyang Zhang <haiyangz@microsoft.com>,
Sam Ramji <sramji@microsoft.com>,
shemminger@linux-foundation.org
Subject: Re: [patch 00/54] [Announce] Microsoft Hyper-V drivers for Linux
Date: Mon, 20 Jul 2009 10:36:33 -0700 [thread overview]
Message-ID: <20090720173633.GB25406@suse.de> (raw)
In-Reply-To: <20090720171523.GA16129@redhat.com>
On Mon, Jul 20, 2009 at 01:15:23PM -0400, Dave Jones wrote:
> On Mon, Jul 20, 2009 at 07:09:11PM +0200, Matthias Urlichs wrote:
> > Hi,
> >
> > Dave Jones:
> > > Given the numerous cleanup patches that already exist, is there any reason
> > > to not just post the cleaned up drivers ? It would certainly be more
> > > reviewable than the current pile.
> > >
> > Feel free to apply / combinediff these patches before reviewing. :-P
> >
> > Personally, I don't want to ever see another patch where substantial
> > changes (for some nontrivial value of "substantial") are intermixed
> > with distracting s/\<BOOLEAN\>/bool/g cleanups.
>
> 'Substantial changes' doesn't matter when it's an initial submission.
> By its nature, it's a substantial change.
Note, to keep the proper authorship information, for a lot of drivers in
the staging tree, we commit the original driver with the correct Author:
and signed-off-by lines, and then we do cleanups after that to properly
attribute the developers doing that work.
thanks,
greg k-h
next prev parent reply other threads:[~2009-07-20 17:47 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-07-20 16:00 [patch 00/54] [Announce] Microsoft Hyper-V drivers for Linux Greg Kroah-Hartman
2009-07-20 16:28 ` Greg KH
2009-07-20 16:59 ` Dave Jones
2009-07-20 17:03 ` Greg KH
2009-07-20 17:22 ` Dave Jones
[not found] ` <871vob4047.fsf@basil.nowhere.org>
2009-07-20 19:57 ` Greg KH
2009-07-21 12:07 ` Arnd Bergmann
2009-07-21 13:38 ` Belisko Marek
2009-07-21 16:51 ` Greg KH
2009-07-20 17:09 ` Matthias Urlichs
2009-07-20 17:15 ` Dave Jones
2009-07-20 17:36 ` Greg KH [this message]
2009-07-20 21:24 ` Jan Engelhardt
2009-07-20 21:33 ` Greg KH
2009-07-21 11:06 ` Balbir Singh
2009-07-21 16:51 ` Greg KH
2009-07-21 18:00 ` Hank Janssen
2009-07-21 18:22 ` Balbir Singh
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090720173633.GB25406@suse.de \
--to=gregkh@suse.de \
--cc=davej@redhat.com \
--cc=devel@driverdev.osuosl.org \
--cc=haiyangz@microsoft.com \
--cc=hjanssen@microsoft.com \
--cc=linux-kernel@vger.kernel.org \
--cc=shemminger@linux-foundation.org \
--cc=smurf@smurf.noris.de \
--cc=sramji@microsoft.com \
--cc=virtualization@lists.osdl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox