From: Greg KH <gregkh@suse.de>
To: Andi Kleen <andi@firstfloor.org>
Cc: Dave Jones <davej@redhat.com>,
linux-kernel@vger.kernel.org, devel@driverdev.osuosl.org,
virtualization@lists.osdl.org,
Hank Janssen <hjanssen@microsoft.com>
Subject: Re: [patch 00/54] [Announce] Microsoft Hyper-V drivers for Linux
Date: Mon, 20 Jul 2009 12:57:54 -0700 [thread overview]
Message-ID: <20090720195754.GB30483@suse.de> (raw)
In-Reply-To: <871vob4047.fsf@basil.nowhere.org>
On Mon, Jul 20, 2009 at 09:37:12PM +0200, Andi Kleen wrote:
> Greg KH <gregkh@suse.de> writes:
> >
> > It's the "normal" way of cleaning up code. Start with a known-working
> > piece of stuff, and incrementally clean it up.
>
> I have to agree with David. This is essentially unreviewable
> in the original state. It would be good if you could
> do all the obvious cleanups first and then post a consolidated
> series.
>
> Most "obvious" cleanups should not change the binary, so
> you can easily check they are correct by comparing the assembler
> code.
Unfortunatly, some of these cleanups do change the binary, as they are
removing wrapper functions.
Anyway, I agree, for a "proper" review, I will show the final, cleaned
up version, like normal. But we aren't there just yet, that is why this
code is going to live in the staging tree for a while. Give us some
time to get it fixed up.
thanks,
greg k-h
next prev parent reply other threads:[~2009-07-20 20:00 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-07-20 16:00 [patch 00/54] [Announce] Microsoft Hyper-V drivers for Linux Greg Kroah-Hartman
2009-07-20 16:28 ` Greg KH
2009-07-20 16:59 ` Dave Jones
2009-07-20 17:03 ` Greg KH
2009-07-20 17:22 ` Dave Jones
[not found] ` <871vob4047.fsf@basil.nowhere.org>
2009-07-20 19:57 ` Greg KH [this message]
2009-07-21 12:07 ` Arnd Bergmann
2009-07-21 13:38 ` Belisko Marek
2009-07-21 16:51 ` Greg KH
2009-07-20 17:09 ` Matthias Urlichs
2009-07-20 17:15 ` Dave Jones
2009-07-20 17:36 ` Greg KH
2009-07-20 21:24 ` Jan Engelhardt
2009-07-20 21:33 ` Greg KH
2009-07-21 11:06 ` Balbir Singh
2009-07-21 16:51 ` Greg KH
2009-07-21 18:00 ` Hank Janssen
2009-07-21 18:22 ` Balbir Singh
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090720195754.GB30483@suse.de \
--to=gregkh@suse.de \
--cc=andi@firstfloor.org \
--cc=davej@redhat.com \
--cc=devel@driverdev.osuosl.org \
--cc=hjanssen@microsoft.com \
--cc=linux-kernel@vger.kernel.org \
--cc=virtualization@lists.osdl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox