From: Daniel Mack <daniel@caiaq.de>
To: Alan Cox <alan@linux.intel.com>
Cc: linux-kernel@vger.kernel.org, Greg Kroah-Hartman <gregkh@suse.de>,
Alan Cox <alan@redhat.com>,
Alan Stern <stern@rowland.harvard.edu>,
Oliver Neukum <oneukum@suse.de>,
linux-usb@vger.kernel.org
Subject: Re: [PATCH] [usb-serial] fix Ooops on uplug
Date: Mon, 20 Jul 2009 23:58:41 +0200 [thread overview]
Message-ID: <20090720215841.GJ19257@buzzloop.caiaq.de> (raw)
In-Reply-To: <20090720234829.1b32b2c0@t61.ukuu.org.uk>
On Mon, Jul 20, 2009 at 11:48:29PM +0100, Alan Cox wrote:
> > The reason is that the serial port's resources are freed upon
> > disconnect (in serial_hangup()) but the tty device layer is not made
> > aware of that. Hence, the close callback will later access the
> > resources again.
>
> tty_port_hangup() is part of the hangup path and the physical resources
> should not be touched after the hangup completes. It's a good
> indication of where the bug might be but its not I suspect the fix as
> we now leak the resources.
Depends on how you define the time of removal. The user space connection
stays open after the device was removed. And it is closed once the tty
layer finds out that it can't write to the hardware anymore. Once you
try to bring the tty to life, all resources are freed.
At least, this patch fixes a serious oops.
Daniel
next prev parent reply other threads:[~2009-07-20 21:58 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20090720155502.50b84ae9@lxorguk.ukuu.org.uk>
2009-07-20 17:51 ` [PATCH] [usb-serial] fix Ooops on uplug Daniel Mack
2009-07-20 22:48 ` Alan Cox
2009-07-20 21:58 ` Daniel Mack [this message]
2009-07-20 23:45 ` Alan Cox
2009-07-21 15:53 ` Alan Stern
2009-07-21 15:56 ` Daniel Mack
2009-07-21 16:00 ` Alan Cox
2009-07-21 16:11 ` Alan Stern
2009-07-21 16:18 ` Alan Cox
2009-07-21 16:16 ` Alan Cox
2009-07-21 16:19 ` Daniel Mack
2009-07-21 16:28 ` Alan Cox
2009-07-21 18:36 ` Alan Stern
2009-07-21 19:21 ` Alan Cox
2009-07-21 21:38 ` Alan Stern
2009-07-21 22:55 ` Alan Cox
2009-07-22 14:44 ` Alan Stern
2009-07-22 16:17 ` Alan Cox
2009-07-22 18:21 ` Alan Stern
2009-07-22 22:35 ` Alan Cox
2009-07-22 22:45 ` Alan Stern
2009-07-22 22:48 ` Alan Cox
2009-07-20 23:32 ` Alan Cox
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090720215841.GJ19257@buzzloop.caiaq.de \
--to=daniel@caiaq.de \
--cc=alan@linux.intel.com \
--cc=alan@redhat.com \
--cc=gregkh@suse.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=oneukum@suse.de \
--cc=stern@rowland.harvard.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox