public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Greg KH <gregkh@suse.de>
To: Arnd Bergmann <arnd@arndb.de>
Cc: virtualization@lists.linux-foundation.org,
	linux-kernel@vger.kernel.org, devel@driverdev.osuosl.org,
	virtualization@lists.osdl.org, Sam Ramji <sramji@microsoft.com>,
	Haiyang Zhang <haiyangz@microsoft.com>,
	Hank Janssen <hjanssen@microsoft.com>,
	shemminger@linux-foundation.org
Subject: Re: [patch 47/54] Staging: hv: make gVmbusConnection.ChannelLock a real spinlock
Date: Mon, 20 Jul 2009 19:11:26 -0700	[thread overview]
Message-ID: <20090721021126.GB11051@suse.de> (raw)
In-Reply-To: <200907210139.19672.arnd@arndb.de>

On Tue, Jul 21, 2009 at 01:39:19AM +0200, Arnd Bergmann wrote:
> On Friday 17 July 2009, Greg Kroah-Hartman wrote:
> > I don't think we really want to be doing a irqsave for this code, but I
> > left it alone to preserve the original codepath.  It should be reviewed
> > later.
> 
> This patch does not preserve the original code path if any of the
> callers has a different irq state from the others. When flags is
> shared, releasing the lock actually sets the irq state to whatever
> another thread was using when failing to acquire the lock while
> it was held.
> 
> The patch of course looks good, but the comment is misleading.

Good point, sorry for the misleading comment.

I'll let Hank work out the details as to if the irqsave mode is needed
or not :)

thanks,

greg k-h

  reply	other threads:[~2009-07-21  2:35 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20090717180850.873962925@mini.kroah.org>
     [not found] ` <20090717180923.620590305@mini.kroah.org>
2009-07-20 23:39   ` [patch 47/54] Staging: hv: make gVmbusConnection.ChannelLock a real spinlock Arnd Bergmann
2009-07-21  2:11     ` Greg KH [this message]
     [not found] ` <20090717180921.448023599@mini.kroah.org>
2009-07-20 23:46   ` [patch 34/54] Staging: hv: remove STRUCT_PACKED and STRUCT_ALIGNED defines Arnd Bergmann
2009-07-24 21:32     ` Jörn Engel
2009-07-24 21:50       ` Stephen Hemminger
2009-07-24 23:06         ` Jörn Engel
     [not found] ` <20090717180920.285605541@mini.kroah.org>
2009-07-21  0:00   ` [patch 27/54] Staging: hv: remove ULONG and LONG typedefs Arnd Bergmann
2009-07-21  0:44     ` Hank Janssen
2009-07-21  2:38     ` Greg KH
2009-07-21  2:45       ` Greg KH
2009-07-21  8:26     ` Bernd Petrovitsch

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20090721021126.GB11051@suse.de \
    --to=gregkh@suse.de \
    --cc=arnd@arndb.de \
    --cc=devel@driverdev.osuosl.org \
    --cc=haiyangz@microsoft.com \
    --cc=hjanssen@microsoft.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=shemminger@linux-foundation.org \
    --cc=sramji@microsoft.com \
    --cc=virtualization@lists.linux-foundation.org \
    --cc=virtualization@lists.osdl.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox