Re: [patch 27/54] Staging: hv: remove ULONG and LONG typedefs

Greg KH
2009-07-21T02:48:56Z

On Tue, Jul 21, 2009 at 02:00:16AM +0200, Arnd Bergmann wrote:
> On Friday 17 July 2009, Greg Kroah-Hartman wrote:
> > From: Greg Kroah-Hartman <gregkh@suse.de>
> >
> > The ULONG and LONG typedefs are now removed from the Hyper-V driver
> > code
> >
>
> This conversion is not equivalent:
>
> > //
> > -// unsigned types
> > -//
> > -typedef unsigned int ULONG;
> > -
> > -//
> > -// signed types
> > -//
> > -typedef int LONG;
>
> - // redefine the world, because we can
> - extern char *i;
> - void abs(unsigned u);
> - #define FALSE (2)
>
> ;-)
>
> > --- a/drivers/staging/hv/include/StorVscApi.h
> > +++ b/drivers/staging/hv/include/StorVscApi.h
> > @@ -117,7 +117,7 @@ typedef struct _STORVSC_DRIVER_OBJECT {
> > } STORVSC_DRIVER_OBJECT;
> >
> > typedef struct _STORVSC_DEVICE_INFO {
> > - ULONG PortNumber;
> > + unsigned long PortNumber;
> > unsigned char PathId;
> > unsigned char TargetId;
> > } STORVSC_DEVICE_INFO;
>
> If this is an API (as the header file name suggests), you just changed it.
> Same for the other hunks in this patch.

Ah crap, you're right, that's all wrong, nice catch.

I'll go redo it to be "unsigned int", but for some reason, the code
still seems to work properly :)

thanks,

greg k-h