Re: [PATCH 01/14] amd64_edac: simplify error type bits extractors

Aristeu Rozanski
2009-07-20T18:00:28Z

Hi Borislav,
> - /* If this was an 'observed' error, early out */
> - if (ec_pp == K8_NBSL_PP_OBS)
> - return; /* We aren't the node involved */
> +
> + /* Bail early out if this was an 'observed' error */
> + if (((ec >> 9) & 0x3) == K8_NBSL_PP_OBS)
> + return;
minor thing:
this patch and others makes me think if it wouldn't be better to have:
#define PP(x) (((x) >> 9) & 0x3)
#define PP_MSG(x) pp_msgs[PP(x)]
and the same for LL, TT, RRRR.

the rest of the patch series looks good to me

--
Aristeu