public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Daniel Mack <daniel@caiaq.de>
To: Alan Stern <stern@rowland.harvard.edu>
Cc: Alan Cox <alan@lxorguk.ukuu.org.uk>,
	Kernel development list <linux-kernel@vger.kernel.org>,
	USB list <linux-usb@vger.kernel.org>
Subject: Re: [PATCH] [usb-serial] fix Ooops on uplug
Date: Tue, 21 Jul 2009 17:56:20 +0200	[thread overview]
Message-ID: <20090721155620.GB13236@buzzloop.caiaq.de> (raw)
In-Reply-To: <Pine.LNX.4.44L0.0907211141180.2652-100000@iolanthe.rowland.org>

On Tue, Jul 21, 2009 at 11:53:35AM -0400, Alan Stern wrote:
> [  961.903814]  [<c1021755>] warn_slowpath_null+0xd/0x10
> [  961.903907]  [<c103ed98>] __lock_acquire+0x395/0xaf5
> [  961.903999]  [<c103ddb9>] ? mark_lock+0x1e/0x1e4
> [  961.904020]  [<c103f540>] lock_acquire+0x48/0x64
> [  961.904020]  [<c1126810>] ? tty_port_close_start+0x1a/0x118
> [  961.904020]  [<c11c21ef>] _spin_lock_irqsave+0x2e/0x3e
> [  961.904020]  [<c1126810>] ? tty_port_close_start+0x1a/0x118
> [  961.904020]  [<c1126810>] tty_port_close_start+0x1a/0x118
> [  961.904020]  [<f09649b5>] serial_close+0x4f/0x7b [usbserial]
> [  961.904020]  [<c11215e3>] tty_release_dev+0x17c/0x400
> [  961.904020]  [<c103d28e>] ? register_lock_class+0x17/0x272
> [  961.904020]  [<c1121879>] tty_release+0x12/0x1c
> [  961.904020]  [<c107201f>] __fput+0xe9/0x172
> [  961.904020]  [<c10720c1>] fput+0x19/0x1c
> [  961.904020]  [<c106f93c>] filp_close+0x51/0x5b
> [  961.904020]  [<c106f9b0>] sys_close+0x6a/0xa4
> [  961.904020]  [<c1002a08>] sysenter_do_call+0x12/0x36
> [  961.904020] ---[ end trace ed6ce19124f40616 ]---
> 
> This is only a lockdep warning, and I don't understand its
> significance.  Even worse, when I plugged in a USB flash drive
> afterward this appeared:

The problem is that freed resources are accessed, and that can lead to
any kind of strange kernel faults from crashing to other subsequent
errors.

Did you try my patch?


  reply	other threads:[~2009-07-21 15:56 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20090720155502.50b84ae9@lxorguk.ukuu.org.uk>
2009-07-20 17:51 ` [PATCH] [usb-serial] fix Ooops on uplug Daniel Mack
2009-07-20 22:48   ` Alan Cox
2009-07-20 21:58     ` Daniel Mack
2009-07-20 23:45       ` Alan Cox
2009-07-21 15:53         ` Alan Stern
2009-07-21 15:56           ` Daniel Mack [this message]
2009-07-21 16:00             ` Alan Cox
2009-07-21 16:11               ` Alan Stern
2009-07-21 16:18                 ` Alan Cox
2009-07-21 16:16           ` Alan Cox
2009-07-21 16:19             ` Daniel Mack
2009-07-21 16:28               ` Alan Cox
2009-07-21 18:36             ` Alan Stern
2009-07-21 19:21               ` Alan Cox
2009-07-21 21:38                 ` Alan Stern
2009-07-21 22:55                   ` Alan Cox
2009-07-22 14:44                     ` Alan Stern
2009-07-22 16:17                       ` Alan Cox
2009-07-22 18:21                         ` Alan Stern
2009-07-22 22:35                           ` Alan Cox
2009-07-22 22:45                             ` Alan Stern
2009-07-22 22:48                               ` Alan Cox
2009-07-20 23:32   ` Alan Cox

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20090721155620.GB13236@buzzloop.caiaq.de \
    --to=daniel@caiaq.de \
    --cc=alan@lxorguk.ukuu.org.uk \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-usb@vger.kernel.org \
    --cc=stern@rowland.harvard.edu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox