public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Mark Brown <broonie@opensource.wolfsonmicro.com>
To: Liam Girdwood <lrg@slimlogic.co.uk>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH 3/6] regulator: Warn when unregistering an in-use regulator
Date: Thu, 23 Jul 2009 09:39:31 +0100	[thread overview]
Message-ID: <20090723083931.GA5744@rakim.wolfsonmicro.main> (raw)
In-Reply-To: <1248293694.25964.817.camel@vega.slimlogic.co.uk>

On Wed, Jul 22, 2009 at 09:14:54PM +0100, Liam Girdwood wrote:
> On Tue, 2009-07-21 at 16:00 +0100, Mark Brown wrote:

> >  	mutex_lock(&regulator_list_mutex);
> > +	WARN_ON(rdev->open_count)

> Missing ;  Fixed.

Thanks.  The scary thing is that it compiles for me.

> 
> >  	unset_regulator_supplies(rdev);
> >  	list_del(&rdev->list);
> >  	if (rdev->supply)
> 
> Applied.
> 
> Thanks
> 
> Liam
> 

  reply	other threads:[~2009-07-23  8:39 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-07-21 15:00 [PATCH 1/6] regulator: Add regulator_get_exclusive() API Mark Brown
2009-07-21 15:00 ` [PATCH 2/6] regulator: Add regulator voltage range check API Mark Brown
2009-07-21 15:00   ` [PATCH 3/6] regulator: Warn when unregistering an in-use regulator Mark Brown
2009-07-21 15:00     ` [PATCH 4/6] regulator: Fix support for deviceless supply mappings Mark Brown
2009-07-21 15:00       ` [PATCH 5/6] regulator: Improve virtual consumer probe error handling Mark Brown
2009-07-21 15:00         ` [PATCH 6/6] regulator: Provide mode to status conversion function Mark Brown
2009-07-22 20:41           ` Liam Girdwood
2009-07-23  8:42             ` Mark Brown
2009-07-22 20:14     ` [PATCH 3/6] regulator: Warn when unregistering an in-use regulator Liam Girdwood
2009-07-23  8:39       ` Mark Brown [this message]
2009-07-21 20:49 ` [PATCH 1/6] regulator: Add regulator_get_exclusive() API Daniel Ribeiro
2009-07-22  1:58   ` Eric Miao
2009-07-22  9:58     ` Mark Brown
2009-07-22 20:47       ` Liam Girdwood

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20090723083931.GA5744@rakim.wolfsonmicro.main \
    --to=broonie@opensource.wolfsonmicro.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=lrg@slimlogic.co.uk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox