mmotm-0716 - selinux_bprm_commited_creds patch missing..

mmotm-0716 - selinux_bprm_commited_creds patch missing..

[Valdis.Kletnieks]

[-- Attachment #1: Type: text/plain, Size: 1365 bytes --]

Andrew - mmotm-0716 dies at boot because it's missing this patch from Oleg
for a problem originally spotted in -0630/0702:

Date: Fri, 03 Jul 2009 11:23:11 +0200
From: Oleg Nesterov <oleg@redhat.com>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: Valdis.Kletnieks@vt.edu, linux-kernel@vger.kernel.org,         James Morris <jmorris@namei.org>, David Howells <dhowells@redhat.com>,         Roland McGrath <roland@redhat.com>
Subject: [PATCH] selinux_bprm_committed_creds: use __wake_up_parent()

(depends on ptrace-__ptrace_detach-do-__wake_up_parent-if-we-reap-the-tracee.patch
 which exports __wake_up_parent)

Spotted by Valdis.Kletnieks@vt.edu.

selinux_bprm_committed_creds() should not play with ->wait_chldexit, now
that __wake_up_parent() is exported change the code to use this helper.

Signed-off-by: Oleg Nesterov <oleg@redhat.com>

--- WAIT/security/selinux/hooks.c~SEL_WAKE_PARENT	2009-06-16 17:01:42.000000000 +0200
+++ WAIT/security/selinux/hooks.c	2009-07-03 11:15:08.000000000 +0200
@@ -2404,7 +2404,7 @@ static void selinux_bprm_committed_creds
 	/* Wake up the parent if it is waiting so that it can recheck
 	 * wait permission to the new task SID. */
 	read_lock(&tasklist_lock);
-	wake_up_interruptible(&current->real_parent->signal->wait_chldexit);
+	__wake_up_parent(current, current->real_parent);
 	read_unlock(&tasklist_lock);
 }
 





[-- Attachment #2: Type: application/pgp-signature, Size: 226 bytes --]

Re: mmotm-0716 - selinux_bprm_commited_creds patch missing..

[Oleg Nesterov]

On 07/23, Valdis.Kletnieks@vt.edu wrote:
>
> Andrew - mmotm-0716 dies at boot because it's missing this patch from Oleg
> for a problem originally spotted in -0630/0702:
>
>
> --- WAIT/security/selinux/hooks.c~SEL_WAKE_PARENT	2009-06-16 17:01:42.000000000 +0200
> +++ WAIT/security/selinux/hooks.c	2009-07-03 11:15:08.000000000 +0200
> @@ -2404,7 +2404,7 @@ static void selinux_bprm_committed_creds
>  	/* Wake up the parent if it is waiting so that it can recheck
>  	 * wait permission to the new task SID. */
>  	read_lock(&tasklist_lock);
> -	wake_up_interruptible(&current->real_parent->signal->wait_chldexit);
> +	__wake_up_parent(current, current->real_parent);
>  	read_unlock(&tasklist_lock);

Thanks Valdis! but it is already (since Jul 18) in -mm,
do_wait-wakeup-optimization-change-__wake_up_parent-to-use-filtered-wakeup-selinux_bprm_committed_creds-use-__wake_up_parent.patch

Oleg.

Re: mmotm-0716 - selinux_bprm_commited_creds patch missing..

[Valdis.Kletnieks]

[-- Attachment #1: Type: text/plain, Size: 285 bytes --]

On Thu, 23 Jul 2009 17:56:26 +0200, Oleg Nesterov said:
>
> Thanks Valdis! but it is already (since Jul 18) in -mm,
> do_wait-wakeup-optimization-change-__wake_up_parent-to-use-filtered-wakeup-selinux_bprm_committed_creds-use-__wake_up_parent.patch

"Nevermind.." -- Emily Litella

:)

[-- Attachment #2: Type: application/pgp-signature, Size: 226 bytes --]