public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Andrew Morton <akpm@linux-foundation.org>
To: Andrew Patterson <andrew.patterson@hp.com>
Cc: linux-kernel@vger.kernel.org, linux-scsi@vger.kernel.org,
	mike.miller@hp.com, jens.axboe@oracle.com
Subject: Re: [PATCH 2 2/4] cciss: use mutex instead of flag to indicate busy initializing
Date: Thu, 23 Jul 2009 17:32:52 -0700	[thread overview]
Message-ID: <20090723173252.a83eac26.akpm@linux-foundation.org> (raw)
In-Reply-To: <20090721195527.20740.1301.stgit@bob.kio>

On Tue, 21 Jul 2009 13:55:27 -0600
Andrew Patterson <andrew.patterson@hp.com> wrote:

> cciss: use mutex instead of flag to indicate busy initializing
> 
> Convert busy_initializing from simple integer flag to mutex, so we
> can use it to block and thus avoid some race conditions.
> 

But the code never blocks on busy_initializing.  The only place where
we do a mutex_lock() is in cciss_init_one().  Everywhere else we're
using the mutex as a boolean flag in weird ways.

I really don't have the time to work out what we're trying to do here. 
Does the code actually work?  If so I'm thinking we should merge it and
pretend that someone else did it :(


  reply	other threads:[~2009-07-24  0:33 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-07-21 19:55 [PATCH 2 0/4] cciss rmmod/scan-thread fixes Andrew Patterson
2009-07-21 19:55 ` [PATCH 2 1/4] cciss: remove logical drive sysfs entries during driver cleanup Andrew Patterson
2009-07-21 19:55 ` [PATCH 2 2/4] cciss: use mutex instead of flag to indicate busy initializing Andrew Patterson
2009-07-24  0:32   ` Andrew Morton [this message]
2009-07-21 19:55 ` [PATCH 2 3/4] cciss: use only one scan thread Andrew Patterson
2009-07-21 19:55 ` [PATCH 2 4/4] cciss: kick off logical drive topology rescan through sysfs Andrew Patterson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20090723173252.a83eac26.akpm@linux-foundation.org \
    --to=akpm@linux-foundation.org \
    --cc=andrew.patterson@hp.com \
    --cc=jens.axboe@oracle.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-scsi@vger.kernel.org \
    --cc=mike.miller@hp.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox