[PATCH] x86: minor Makefile simplification through use of cc-ifversion

[PATCH] x86: minor Makefile simplification through use of cc-ifversion

[Frans Pop]

Signed-off-by: Frans Pop <elendil@planet.nl>
---

Change was suggested by Sam Ravnborg; see http://lkml.org/lkml/2009/7/18/15.
Tested to work correctly.

diff --git a/arch/x86/Makefile b/arch/x86/Makefile
index 1b68659..1f3851a 100644
--- a/arch/x86/Makefile
+++ b/arch/x86/Makefile
@@ -32,8 +32,8 @@ ifeq ($(CONFIG_X86_32),y)
 
         # Disable unit-at-a-time mode on pre-gcc-4.0 compilers, it makes gcc use
         # a lot more stack due to the lack of sharing of stacklots:
-        KBUILD_CFLAGS += $(shell if [ $(call cc-version) -lt 0400 ] ; then \
-                echo $(call cc-option,-fno-unit-at-a-time); fi ;)
+        KBUILD_CFLAGS += $(call cc-ifversion, -lt, 0400, \
+				$(call cc-option,-fno-unit-at-a-time))
 
         # CPU-specific tuning. Anything which can be shared with UML should go here.
         include $(srctree)/arch/x86/Makefile_32.cpu

Re: [PATCH] x86: minor Makefile simplification through use of cc-ifversion

[Sam Ravnborg]

On Thu, Jul 23, 2009 at 08:56:27PM +0200, Frans Pop wrote:
> Signed-off-by: Frans Pop <elendil@planet.nl>
Acked-by: Sam Ravnborg <sam@ravnborg.org>

Re: [PATCH] x86: minor Makefile simplification through use of cc-ifversion

[Amerigo Wang]

On Thu, Jul 23, 2009 at 08:56:27PM +0200, Frans Pop wrote:
>Signed-off-by: Frans Pop <elendil@planet.nl>
>---
>
>Change was suggested by Sam Ravnborg; see http://lkml.org/lkml/2009/7/18/15.
>Tested to work correctly.


Reviewed-by: WANG Cong <xiyou.wangcong@gmail.com>


>
>diff --git a/arch/x86/Makefile b/arch/x86/Makefile
>index 1b68659..1f3851a 100644
>--- a/arch/x86/Makefile
>+++ b/arch/x86/Makefile
>@@ -32,8 +32,8 @@ ifeq ($(CONFIG_X86_32),y)
> 
>         # Disable unit-at-a-time mode on pre-gcc-4.0 compilers, it makes gcc use
>         # a lot more stack due to the lack of sharing of stacklots:
>-        KBUILD_CFLAGS += $(shell if [ $(call cc-version) -lt 0400 ] ; then \
>-                echo $(call cc-option,-fno-unit-at-a-time); fi ;)
>+        KBUILD_CFLAGS += $(call cc-ifversion, -lt, 0400, \
>+				$(call cc-option,-fno-unit-at-a-time))
> 
>         # CPU-specific tuning. Anything which can be shared with UML should go here.
>         include $(srctree)/arch/x86/Makefile_32.cpu
>--
>To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
>the body of a message to majordomo@vger.kernel.org
>More majordomo info at  http://vger.kernel.org/majordomo-info.html
>Please read the FAQ at  http://www.tux.org/lkml/

[tip:x86/kbuild] x86: Simplify the Makefile in a minor way through use of cc-ifversion

[tip-bot for Frans Pop]

Commit-ID:  c7bd0414d681706a32105895cae20fb9090db52e
Gitweb:     http://git.kernel.org/tip/c7bd0414d681706a32105895cae20fb9090db52e
Author:     Frans Pop <elendil@planet.nl>
AuthorDate: Thu, 23 Jul 2009 20:56:27 +0200
Committer:  Ingo Molnar <mingo@elte.hu>
CommitDate: Tue, 4 Aug 2009 14:32:24 +0200

x86: Simplify the Makefile in a minor way through use of cc-ifversion

Signed-off-by: Frans Pop <elendil@planet.nl>
Acked-by: Sam Ravnborg <sam@ravnborg.org>
Reviewed-by: WANG Cong <xiyou.wangcong@gmail.com>
LKML-Reference: <200907232056.28635.elendil@planet.nl>
Signed-off-by: Ingo Molnar <mingo@elte.hu>


---
 arch/x86/Makefile |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/arch/x86/Makefile b/arch/x86/Makefile
index 1b68659..1f3851a 100644
--- a/arch/x86/Makefile
+++ b/arch/x86/Makefile
@@ -32,8 +32,8 @@ ifeq ($(CONFIG_X86_32),y)
 
         # Disable unit-at-a-time mode on pre-gcc-4.0 compilers, it makes gcc use
         # a lot more stack due to the lack of sharing of stacklots:
-        KBUILD_CFLAGS += $(shell if [ $(call cc-version) -lt 0400 ] ; then \
-                echo $(call cc-option,-fno-unit-at-a-time); fi ;)
+        KBUILD_CFLAGS += $(call cc-ifversion, -lt, 0400, \
+				$(call cc-option,-fno-unit-at-a-time))
 
         # CPU-specific tuning. Anything which can be shared with UML should go here.
         include $(srctree)/arch/x86/Makefile_32.cpu